Python3.8fix multiprocessing work around #147
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you to the authors for their work on this tool.
I found a workaround that allows the multiprocessing as written to work on Python versions later than 3.7.
By setting:
mp.set_start_method('fork')
we can override the new default on some systems to use the
spawn
methodSee these for references on the issue:
deeptools/HiCExplorer#628
https://chrissardegna.com/blog/multiprocessing-changes-python-3-8/
Since Python 3.7 is now officially depreciated, it is necessary to support more recent versions of python.
I have not tested this modification on versions newer than 3.8, but I would expect it to work.
I only bumped the required python version to a max of 3.8 but we can modify that when we confirm that additional versions are working.
This should fix this posted issue:
#137