Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3.8fix multiprocessing work around #147

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MLKaufman
Copy link

@MLKaufman MLKaufman commented Jan 18, 2024

Thank you to the authors for their work on this tool.

I found a workaround that allows the multiprocessing as written to work on Python versions later than 3.7.
By setting:
mp.set_start_method('fork')
we can override the new default on some systems to use the spawn method

See these for references on the issue:
deeptools/HiCExplorer#628
https://chrissardegna.com/blog/multiprocessing-changes-python-3-8/

Since Python 3.7 is now officially depreciated, it is necessary to support more recent versions of python.

I have not tested this modification on versions newer than 3.8, but I would expect it to work.

I only bumped the required python version to a max of 3.8 but we can modify that when we confirm that additional versions are working.

This should fix this posted issue:
#137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant