Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch fqns for torch 2.3.0 #3210

Merged
merged 7 commits into from
Apr 30, 2024
Merged

Patch fqns for torch 2.3.0 #3210

merged 7 commits into from
Apr 30, 2024

Conversation

snarayan21
Copy link
Contributor

What does this PR do?

Based on this fix that got merged to PyTorch -- we need to patch for torch 2.3.0 since only got merged in yesterday.

See jira link for issue here. tl;dr this fixes an issue where FQNs for loading optimizer state were incorrect when using both use_orig_params: False and activation checkpointing.

This is only an issue with torch 2.3.0.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@mvpatel2000
Copy link
Contributor

Please hold until #3209

b-chu
b-chu approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@b-chu b-chu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3209 is merged, thanks for the PR!

@snarayan21
Copy link
Contributor Author

Going to wait until composer CI gets to a better state, then address gpu test failures

@snarayan21 snarayan21 merged commit ffb40c0 into dev Apr 30, 2024
15 checks passed
@snarayan21 snarayan21 deleted the saaketh/get_fqns_patch branch April 30, 2024 18:21
j316chuck pushed a commit that referenced this pull request May 16, 2024
@snarayan21
Patch fqns for torch 2.3.0 (#3210)
ec753e0 
* fqn patch

* fsdp import

* patch fqns

* patch torch

* linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-chu b-chu b-chu approved these changes

@mvpatel2000 mvpatel2000 Awaiting requested review from mvpatel2000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snarayan21 @mvpatel2000 @b-chu