Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recaser trainer updated to support IRSTLM as well. #3

Merged
merged 2 commits into from
Nov 25, 2011

Conversation

Jehan
Copy link

@Jehan Jehan commented Nov 25, 2011

A per discussions on the mailing list, everyone who wants to use IRSTLM instead of SRILM for training the recaser was modifying train-recaser.perl. Rather than always doing this (and probably see other messages about this on the list), I thought it might be worth updating the script.

Note that by default, the script will still use SRILM, which prevent from breakage any existing script calling the current version of train-recaser.perl.
To use IRSTLM instead of SRILM, only adding "-lm irstlm" on the command line is enough.
In case build-lm.sh is not in $PATH, there is also a new option -build-lm which allows one to specify the given path of the script to use (with build-lm.sh command line syntax).

If anyone wants to add other language models (for instance KenLM would be great, after all default in Moses!), that will be easy using the -lm option.
Thanks.

Jehan added 2 commits November 25, 2011 02:16
By default, it will still use SRILM so that any previous use of this script from others won't be broken.
To switch to IRSTLM training, simply add "-lm irslm" command line option.
Also if build-lm.sh is not accessible from $PATH, the option "-build-lm /path/to/build-lm.sh" is also available.
@xhudik
Copy link

xhudik commented Nov 25, 2011

great idea, I'm using irstlm for recasing as well, however, I thought the
majority is still using srilm therefore I didn't pull my script for irstlm.

cheers, Toams

On Fri, Nov 25, 2011 at 3:48 AM, Jehan <
reply@reply.github.com

wrote:

A per discussions on the mailing list, everyone who wants to use IRSTLM
instead of SRILM for training the recaser was modifying train-recaser.perl.
Rather than always doing this (and probably see other messages about this
on the list), I thought it might be worth updating the script.

Note that by default, the script will still use SRILM, which prevent from
breakage any existing script calling the current version of
train-recaser.perl.
To use IRSTLM instead of SRILM, only adding "-lm irstlm" on the command
line is enough.
In case build-lm.sh is not in $PATH, there is also a new option -build-lm
which allows one to specify the given path of the script to use (with
build-lm.sh command line syntax).

If anyone wants to add other language models (for instance KenLM would be
great, after all default in Moses!), that will be easy using the -lm option.
Thanks.

You can merge this Pull Request by running:

git pull https://github.com/myGengo/mosesdecoder master

Or you can view, comment on it, or merge it online at:

#3

-- Commit Summary --

  • - Recaser train script updated to support IRSTLM as well.
  • - Coding style fix: use the upstream coding style.

-- File Changes --

M scripts/recaser/train-recaser.perl (22)

-- Patch Links --

https://github.com/moses-smt/mosesdecoder/pull/3.patch
https://github.com/moses-smt/mosesdecoder/pull/3.diff


Reply to this email directly or view it on GitHub:
#3

@KTamas
Copy link

KTamas commented Nov 25, 2011

+1, we use IRSTLM too so this will be very useful.

rsennrich added a commit that referenced this pull request Nov 25, 2011
Recaser trainer updated to support IRSTLM as well.
@rsennrich rsennrich merged commit 9ecf6f5 into moses-smt:master Nov 25, 2011
rsennrich added a commit that referenced this pull request May 24, 2012
Recaser trainer updated to support IRSTLM as well.
hieuhoang pushed a commit that referenced this pull request Dec 17, 2013
hieuhoang pushed a commit that referenced this pull request Jul 21, 2017
Adding CBTM with additional feature scores
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants