Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resident demographic data are not rendered in requested language #656

Closed
Anushree09-N opened this issue Mar 20, 2023 · 2 comments
Closed
Assignees
Labels
bug Something isn't working Critical HotFix Hotfix release moved-to-jira triaged Triage completed
Milestone

Comments

@Anushree09-N
Copy link

Describe the bug
Resident demographic data are not rendered in requested language

To Reproduce
Prerequisite: Environment configured language is eng & ara. Create packet from regclient by filling data in both the language.

  1. Unlock the app
  2. Navigate to settings page
  3. change the Language to arabic
  4. Navigate back to HOME page
  5. Click on ADD ID
  6. Enter VID
  7. Download VC and view

Expected behavior
Download credential API in mimoto is returning back the response in two language, likewise app when VC download is requested in arabic language screen data of VC should also be in arabic.

Actual behavior
When VC is requested all labels are chenged to arabic but demographic details of the credentials are rendered in arabic language.

Screenshots
Download credential API:
image

VC in the Inji app after download:
image

Add the screenshot of the profile page with commit id
IMG20230320115926

Smartphone (please complete the following information):

Device: Redmi note 10 lite

Where does the issue occur: Wallet/Verifier?
N/A

Logs of wallet and verifier:
Cannot get logs in release build

Additional context
This is not device specific issue.
VID: 2396187952165042
Response from API:

responsedwnldcred1.txt

@Anushree09-N Anushree09-N added bug Something isn't working triage This issue is pending confirmation and planning and should not be worked on yet Critical labels Mar 20, 2023
@Sujithbn Sujithbn added this to the 24th MAR milestone Mar 21, 2023
@Sujithbn Sujithbn assigned krishnakumar4a4 and unassigned Sujithbn Mar 21, 2023
@Sujithbn Sujithbn moved this to To do (under triage) in MOSIP Inji issues tracking Mar 21, 2023
@tilak-puli tilak-puli moved this from To do (under triage) to Development in MOSIP Inji issues tracking Mar 23, 2023
PoojaBabusing pushed a commit to tw-mosip/inji-wallet that referenced this issue Mar 23, 2023
PoojaBabusing pushed a commit to tw-mosip/inji-wallet that referenced this issue Mar 24, 2023
PoojaBabusing pushed a commit to tw-mosip/inji-wallet that referenced this issue Mar 24, 2023
PoojaBabusing pushed a commit to tw-mosip/inji-wallet that referenced this issue Mar 24, 2023
vijay151096 added a commit to tw-mosip/inji-wallet that referenced this issue Mar 24, 2023
…hree Letter language code to two letter language code
PoojaBabusing pushed a commit to tw-mosip/inji-wallet that referenced this issue Mar 27, 2023
PoojaBabusing pushed a commit to tw-mosip/inji-wallet that referenced this issue Mar 27, 2023
…e language selected and handled compatibility between 3 and 2 letter language code
vijay151096 added a commit to tw-mosip/inji-wallet that referenced this issue Mar 27, 2023
vijay151096 added a commit to tw-mosip/inji-wallet that referenced this issue Mar 28, 2023
PoojaBabusing pushed a commit to tw-mosip/inji-wallet that referenced this issue Mar 28, 2023
PoojaBabusing pushed a commit to tw-mosip/inji-wallet that referenced this issue Mar 29, 2023
PoojaBabusing pushed a commit to tw-mosip/inji-wallet that referenced this issue Mar 29, 2023
PoojaBabusing pushed a commit to tw-mosip/inji-wallet that referenced this issue Mar 29, 2023
tilak-puli added a commit to tw-mosip/inji-wallet that referenced this issue Mar 30, 2023
fix(mosip#656): Resident demographic data are not rendered in requested language
@Sujithbn Sujithbn added the HotFix Hotfix release label Apr 3, 2023
@Sujithbn Sujithbn added triaged Triage completed and removed triage This issue is pending confirmation and planning and should not be worked on yet labels Apr 3, 2023
@PoojaBabusing PoojaBabusing moved this from Development to Merged in MOSIP Inji issues tracking Apr 4, 2023
@Pragya279
Copy link

This bug has been moved to Jira.
Link to Jira bug: https://mosip.atlassian.net/browse/MOSIP-26848

@krishnakumar4a4 krishnakumar4a4 moved this from Merged to Code review in MOSIP Inji issues tracking Apr 6, 2023
PoojaBabusing pushed a commit to tw-mosip/inji-wallet that referenced this issue Apr 6, 2023
PoojaBabusing pushed a commit to tw-mosip/inji-wallet that referenced this issue Apr 6, 2023
PoojaBabusing pushed a commit to tw-mosip/inji-wallet that referenced this issue Apr 6, 2023
ckm007 added a commit that referenced this issue Jun 2, 2023
…es, permissions enhancements, Storage Optimisation, iOS build automation (#736)

* feat(#656): [Pooja|Vijay] get demogarphic data for selected language

* feat(#656): [Pooja|Vijay] refactor to generate language code map for two letter lnaguage codes only

* feat(#656): [Pooja|Vijay] refactor to generate language code map

* fix(#675): [Bhargavi|Adityan] resolve the input focus issue and display AID screen when we close the otp screen

* fix(#490): [Vijay] show the same binded vc only once which is the recent one,  when IDP portal QRCode is scanned.

* fix(#490): [Vijay] refactor selectBindedVCs to get only myVCs which is recently added.

* fix(#490): [Vijay] refactor selectBindedVCs to get only myVCs which is recently added.

* fix(#490): [Vijay] refactor selectBindedVCs to get only myVCs which is recently added.

* chore: add steps to view the entire DB of inji in Readme

* fix(#675): [Bhargavi|Adityan] resolve the input focus issue and display AID screen when we close the otp screen

* feat(#656): [Pooja|Vijay] get demogarphic data for selected language

* feat(#656): [Pooja|Vijay] refactor to generate language code map for two letter lnaguage codes only

* feat(#656): [Pooja|Vijay] refactor to generate language code map

* feat(#26879): [Alka|Vijay] mmkv storage implementation for meta data and store vc data on file system

Issue Link: #618

* refactor(#618): [Vijay|Alka] refactor storage method and variable name to follow convention

* Update android-custom-build.yml

* refactor(#42): fixed duplicate symol issue on iOS by making changes in node_modules

* chore(#696): bump up tuvali version for windows build

* fix(#223): [Bhargavi|Pooja] add translations for missing fields in all languages

* feat(#26879): [Alka|Vijay] mmkv storage implementation for meta data and store vc data on file system

Issue Link: #618

* refactor(#26879): [Vijay|Alka] refactor storage method and variable name to follow convention

* refactor(#26879): fixed duplicate symol issue on iOS by making changes in node_modules

* chore(#26879): avoid any minor or patch update for react-native-mmkv-storage library

This will avoid conflicts with patch-packaging done to resolve same method name conflicts.

* chore(#26879): avoid any minor or patch update for react-native-mmkv-storage library

This will avoid conflicts with patch-packaging done to resolve same method name conflicts.

* fix(#223): [Bhargavi|Pooja] add filipino locale to date-fns using patch-package

* refactor(#26879): reformat storage.ts file to export class instead of all method

* refactor(#26879): reformat storage.ts file to export class instead of all method

* refactor(#26879): restructured directory path to save the VC and renamed some methods

* refactor(#26879): restructured directory path to save the VC and renamed some methods

* chore: bump up the tuvali version to v0.3.11 for release 19-04-2023

* fix(#26879): check for directory path existence before delete the entire folder of VC

* fix(#26879): check for directory path existence before delete the entire folder of VC

* fix(#490): [Vijay] refactor selectBindedVCs to get only myVCs which is recently added.

* fix(#490): [Vijay] refactor selectBindedVCs to get only myVCs which is recently added.

* chore: bump up faceauth-sdk in Podfile.lock

* fix(#223): [Bhargavi] remove indentation changes in hin.json

* fix(#223): [Bhargavi|Pooja] add translations for missing fields in all languages

* fix(#223): [Bhargavi|Pooja] add filipino locale to date-fns using patch-package

* fix(#223): [Bhargavi] remove indentation changes in hin.json

* fix(#INJI-80): [Vijay] use the recently generated thumbprint for all the binded vc's with same UIN

Issue Link: https://mosip.atlassian.net/browse/INJI-80

* fix(#INJI-80): [Vijay] use the recently generated thumbprint for all the binded vc's with same UIN

Issue Link: https://mosip.atlassian.net/browse/INJI-80

* fix(#INJI-80): [Vijay] encrypt the thumbprint before storing them in the Storage.

* fix(#INJI-80): [Vijay] update typegen for QRLoginMachine and remove unused imports

* feat(#695): show error code in ble error popup

* feat(#695): remove ble error handling form nearby scan machine

* feat(#695): change error code from int to string

* feat(#695): show error code in ble error popup

* feat(#695): remove ble error handling form nearby scan machine

* feat(#28): add translations for error code hint

* fix(#INJI-80): [Vijay] encrypt the thumbprint before storing them in the Storage.

* fix(#INJI-80): [Vijay] update typegen for QRLoginMachine and remove unused imports

* fix(#INJI-34): [Vijay] fix rtl missing tab indicator

Issue Link: https://mosip.atlassian.net/browse/INJI-34

* fix(#INJI-34): [Vijay] fix rtl missing tab indicator

Issue Link: https://mosip.atlassian.net/browse/INJI-34

* fix(#INJI-36): [Vijay] mention upstream pr in patch

Issue Link: https://mosip.atlassian.net/browse/INJI-36

* fix(#INJI-36): [Vijay] mention upstream pr in patch

Issue Link: https://mosip.atlassian.net/browse/INJI-36

* feat(#28):[Tilak] add missing translations

* fix(INJI-39): add new Bluetooth permission for Android12

Reason for adding BLUETOOTH_{SCAN,CONNECT,ADVERTISE}

- enables Android12(API level31 & above) devices to scan for BLE
  peripherals
  ref: https://developer.android.com/guide/topics/connectivity/bluetooth/permissions#declare-android12-or-higher
  without this changeset, an exception is thrown
- this permission was added in API level 31, hence bumped up
  compileSdkVersion

Co-authored-by: Alka Prasad <prasadalka1998@gmail.com>

* fix(INJI-39): assert that BLE scanning doesn't derive device location

* feat(#INJI-42): [Kiruthika/Bhargavi] show error overlay if saving fails while downloading VC

Issue Link: https://mosip.atlassian.net/browse/INJI-42

* feat(#INJI-42): [Kiruthika/Bhargavi] add translations for storage full error message

Issue Link: https://mosip.atlassian.net/browse/INJI-42

* feat(#INJI-42): [Kiruthika/Bhargavi] modify error message for handling diskfull error while receiving VC

mmkv storage or fs throws 'No space left on device' error message when the storing fails

Issue Link: https://mosip.atlassian.net/browse/INJI-42

* chore: bump up the tuvali version to v0.3.12 for release 19-05-2023

* feat(#INJI-42): [Kiruthika/Bhargavi] show the card in loading state until vc details are successfully stored

Issue Link: https://mosip.atlassian.net/browse/INJI-42

* refactor(#INJI-42): [Kiruthika/Bhargavi] add translations for diskfull error in VcDetails & MyVcsTab

Issue Link: https://mosip.atlassian.net/browse/INJI-42

* feat(#71): [Tilak] Show error code hint only if code is available

* refactor(#INJI-42): [Kiruthika/Bhargavi] revert import optimizations

Issue Link: https://mosip.atlassian.net/browse/INJI-42

* refactor(#INJI-42): [Kiruthika/Bhargavi] extract ErrorMessageOverlay component

Issue Link: https://mosip.atlassian.net/browse/INJI-42

* refactor(#INJI-42): [Kiruthika/Bhargavi] change 'No space left on device' to 'ENOSPC' while checking disk full error

When writing to storage fails, this error 'write failed: ENOSPC (No space left on device)' is thrown by react-native-mmkv-storage & react-native-fs. This changes were made as error code (ENOSPC) has less chances of modification in the latest versions of library we use.

Issue Link: https://mosip.atlassian.net/browse/INJI-42

* refactor(#INJI-42): [Kiruthika/Bhargavi] change the state to idle after dismissing saving failed overlay in MyVcs screen

Issue Link: https://mosip.atlassian.net/browse/INJI-42

* refactor(#INJI-42): [Kiruthika/Bhargavi] add comment about ENOSPC error code

Issue Link: https://mosip.atlassian.net/browse/INJI-42

Co-authored-by: null <16505295+bhargavi@users.noreply.github.com>

* refactor(#INJI-42): [Kiruthika/Bhargavi] extract vc item contents & activation status into separate components

Issue Link: https://mosip.atlassian.net/browse/INJI-42

* refactor(#INJI-42): [Kiruthika/Bhargavi] extract vc item wallet unverified & verified activation details into separate components

Issue Link: https://mosip.atlassian.net/browse/INJI-42

* fix(INJI-39): add new Bluetooth permission for Android12

Reason for adding BLUETOOTH_{SCAN,CONNECT,ADVERTISE}

- enables Android12(API level31 & above) devices to scan for BLE
  peripherals
  ref: https://developer.android.com/guide/topics/connectivity/bluetooth/permissions#declare-android12-or-higher
  without this changeset, an exception is thrown
- this permission was added in API level 31, hence bumped up
  compileSdkVersion

Co-authored-by: Alka Prasad <prasadalka1998@gmail.com>

* fix(INJI-39): assert that BLE scanning doesn't derive device location

* INJI-29 | 31 - iOS automation workflow and Android PR workflow (#725)

* Test update readme for read access

Signed-off-by: adityankannan-tw <109274996+adityankannan-tw@users.noreply.github.com>

* iOS workflow added

* iOS slack webhook added

* Add a workflow file to build app for every push

* Add empty debug keystore file to populate it

* Add empty debug keystore file to populate it

* fastlane match file added

* modify api_key duration

* Remove keystore exemption from git ignore

* Check for debug keystore file in app directory

* Give permission for keystore file to access it

* Give permission for keystore file to access it

* Print the env variables for keystore

* Use same password for both store and key and build the app

* Use same password for both and generate in app and build the app

* Print debug keystore path and debug it

* Print debug keystore path and debug it in fastfile

* Export from the current folder and remove sudo

* Generate release keystore and build the app

* Generate release keystore and build the app try 2

* Generate release keystore and build the app try 3

* Add encoded api key

* fastlane match password added

* fastlane match key added

* Match file env modified

* set keystore env for specific tasks and build the app

* set keystore env for specific tasks and build the app try 2

* set keystore env for specific tasks and build the app try 3

* set keystore env for specific tasks and build the app try 4

* set keystore env for specific tasks and build the app try 5

* bumping version

* create a env file to store env variables and build the app

* create a env file in fastlane and load it to build the app

* create a env file in fastlane and load it to build the app try 2

* app id added

* signing identities added

* Pass env from workflow to fastfile and build

* Build app in workflow file only

* Update the version code in build.gradle and build the app

* Update the version code in build.gradle and confirm changes by logging

* Update the version code in build.gradle and confirm changes by logging 2

* Double check the version code changes and build the app

* Add logs to see version code is changes or not

* Add logs to see version code is changes or not try 2

* Add logs to see version code is changes or not try 3

* Add logs to see version code is changes and give execute permission

* Build app without exporting the keystore

* Build app without exporting the keystore and bump version

* Build app by exporting the keystore in a task

* Build the app without fastlane

* unlock keychain key added

* fastfile changes

* config modified

* xcode proj config added

* xcode proj config added

* fastfile config added

* fastfile config added

* modified cert

* Fastfile config added

* updated key to test workflow

* Fastfile config updated

* changed to manual match of provisioning profile

* Check for git tag

* Check for git tag and echo it

* Check for git tag using try catch

* Check for git tag and print it

* Add a tag and try to print it

* Add a tag and try to run the task

* Add a tag and try to run the task try 2

* Change keystore path and build the app

* Change keystore path in build.gradle and build the app

* fastfile configured

* match modified

* match modified

* Clean up the code base

* Clean up the code base

* Clean up the code base and give permission

* testers added

* Internal testers group

* Trigger on workflow push

* fastfile changes for testers

* fastfile changes for testers

* fastfile changes for testers

* fastfile changes for testers

* fastfile changes for testers

* Add a PR trigger for ci-publish

* Add a env for keystore job

* Added actual env for testers

* Add a env for keystore job and export job

* Adjust env variables for jobs

* Make env as global

* Refactor the code base and clear files

* [Dhivya|Adityan] feat(#INJI-29|31)[Android][iOS] PR trigger and automate build using fastlane and push iOS build to test flight

* [Dhivya|Adityan] refactor(#INJI-29|31)[Android][iOS] Change the backend url and add comments and rename apk output

* [Dhivya|Adityan] refactor(#INJI-29|31)[Android][iOS] Change the workflow name

---------

Signed-off-by: adityankannan-tw <109274996+adityankannan-tw@users.noreply.github.com>
Co-authored-by: MOSIP <mosip@MOSIPs-MacBook-Air.local>
Co-authored-by: Adityan Kannan <adityankannan@Adityans-MacBook-Pro.local>
Co-authored-by: Dhivya <dhivya.v@thoughtworks.com>

* INJI-29 Modified from self-hosted to mac-runner (#728)

* Update android-custom-build.yml

* Test update readme for read access

Signed-off-by: adityankannan-tw <109274996+adityankannan-tw@users.noreply.github.com>

* iOS workflow added

* iOS slack webhook added

* Add a workflow file to build app for every push

* Add empty debug keystore file to populate it

* Add empty debug keystore file to populate it

* fastlane match file added

* modify api_key duration

* Remove keystore exemption from git ignore

* Check for debug keystore file in app directory

* Give permission for keystore file to access it

* Give permission for keystore file to access it

* Print the env variables for keystore

* Use same password for both store and key and build the app

* Use same password for both and generate in app and build the app

* Print debug keystore path and debug it

* Print debug keystore path and debug it in fastfile

* Export from the current folder and remove sudo

* Generate release keystore and build the app

* Generate release keystore and build the app try 2

* Generate release keystore and build the app try 3

* Add encoded api key

* fastlane match password added

* fastlane match key added

* Match file env modified

* set keystore env for specific tasks and build the app

* set keystore env for specific tasks and build the app try 2

* set keystore env for specific tasks and build the app try 3

* set keystore env for specific tasks and build the app try 4

* set keystore env for specific tasks and build the app try 5

* bumping version

* create a env file to store env variables and build the app

* create a env file in fastlane and load it to build the app

* create a env file in fastlane and load it to build the app try 2

* app id added

* signing identities added

* Pass env from workflow to fastfile and build

* Build app in workflow file only

* Update the version code in build.gradle and build the app

* Update the version code in build.gradle and confirm changes by logging

* Update the version code in build.gradle and confirm changes by logging 2

* Double check the version code changes and build the app

* Add logs to see version code is changes or not

* Add logs to see version code is changes or not try 2

* Add logs to see version code is changes or not try 3

* Add logs to see version code is changes and give execute permission

* Build app without exporting the keystore

* Build app without exporting the keystore and bump version

* Build app by exporting the keystore in a task

* Build the app without fastlane

* unlock keychain key added

* fastfile changes

* config modified

* xcode proj config added

* xcode proj config added

* fastfile config added

* fastfile config added

* modified cert

* Fastfile config added

* updated key to test workflow

* Fastfile config updated

* changed to manual match of provisioning profile

* Check for git tag

* Check for git tag and echo it

* Check for git tag using try catch

* Check for git tag and print it

* Add a tag and try to print it

* Add a tag and try to run the task

* Add a tag and try to run the task try 2

* Change keystore path and build the app

* Change keystore path in build.gradle and build the app

* fastfile configured

* match modified

* match modified

* Clean up the code base

* Clean up the code base

* Clean up the code base and give permission

* testers added

* Internal testers group

* Trigger on workflow push

* fastfile changes for testers

* fastfile changes for testers

* fastfile changes for testers

* fastfile changes for testers

* fastfile changes for testers

* Add a PR trigger for ci-publish

* Add a env for keystore job

* Added actual env for testers

* Add a env for keystore job and export job

* Adjust env variables for jobs

* Make env as global

* Refactor the code base and clear files

* [Dhivya|Adityan] feat(#INJI-29|31)[Android][iOS] PR trigger and automate build using fastlane and push iOS build to test flight

* [Dhivya|Adityan] refactor(#INJI-29|31)[Android][iOS] Change the backend url and add comments and rename apk output

* [Dhivya|Adityan] refactor(#INJI-29|31)[Android][iOS] Change the workflow name

* configure macos runner

* modify command for fastlane

---------

Signed-off-by: adityankannan-tw <109274996+adityankannan-tw@users.noreply.github.com>
Co-authored-by: Keshav Mishra <chandrakeshavmishra@gmail.com>
Co-authored-by: Monobikash Das <43202165+MonobikashDas@users.noreply.github.com>
Co-authored-by: adityankannan-tw <109274996+adityankannan-tw@users.noreply.github.com>
Co-authored-by: MOSIP <mosip@MOSIPs-MacBook-Air.local>
Co-authored-by: Adityan Kannan <adityankannan@Adityans-MacBook-Pro.local>
Co-authored-by: adityankannan-tw <adityan.kannan@thoughtworks.com>

* Revert "INJI-29 Modified from self-hosted to mac-runner (#728)" (#729)

This reverts commit b35bfbc.

* modify from self-hosted runner to github runner (#730)

* chore: bump up the tuvali version to v0.4.0 for release 30-05-2023

* revert build.gradle changes

* fix:(#29) iOS build workflow fix

* chore: Add appstore connect groups in workflow

* chore: testers group order same as app store connect

---------

Signed-off-by: adityankannan-tw <109274996+adityankannan-tw@users.noreply.github.com>
Co-authored-by: RAVI KUMAR PASUMARTHY <292991+ravikp@users.noreply.github.com>
Co-authored-by: Monobikash Das <43202165+MonobikashDas@users.noreply.github.com>
Co-authored-by: Pooja Babusing <poojababusing@Pooja-Babusingh.local>
Co-authored-by: Tilak Puli <34330361+tilak-puli@users.noreply.github.com>
Co-authored-by: PuBHARGAVI <saibhargavi.puvvada@gmail.com>
Co-authored-by: Vijay <vijayskumarsuresh@gmail.com>
Co-authored-by: vijay151096 <94220135+vijay151096@users.noreply.github.com>
Co-authored-by: Alka Prasad <prasadalka1998@gmail.com>
Co-authored-by: Keshav Mishra <chandrakeshavmishra@gmail.com>
Co-authored-by: Krishna Kumar Thokala <krishna.thokala2010@gmail.com>
Co-authored-by: Harsh Vardhan <harsh59v@gmail.com>
Co-authored-by: Tilak Puli <tilakpuli15@gmail.com>
Co-authored-by: KiruthikaJeyashankar <kiruthika.j@thoughtworks.com>
Co-authored-by: null <16505295+bhargavi@users.noreply.github.com>
Co-authored-by: adityankannan-tw <109274996+adityankannan-tw@users.noreply.github.com>
Co-authored-by: MOSIP <mosip@MOSIPs-MacBook-Air.local>
Co-authored-by: Adityan Kannan <adityankannan@Adityans-MacBook-Pro.local>
Co-authored-by: adityankannan-tw <adityan.kannan@thoughtworks.com>
@Raginikrishnamurthy
Copy link
Contributor

Issue verified and closed in jira https://mosip.atlassian.net/browse/INJI-44 , hence closing on Github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Critical HotFix Hotfix release moved-to-jira triaged Triage completed
Projects
Status: Merged
Development

No branches or pull requests

7 participants