-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HotfixRelease 02-06-2023] UI improvements, device specific issue fixes, permissions enhancements, Storage Optimisation, iOS build automation #736
Merged
ckm007
merged 120 commits into
mosip:release-0.9.x
from
tw-mosip:hotfix-release-02-06-23
Jun 2, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Release 17-03-2023] iOS code refactor & UI improvements
Release 24-03-2023 Changes
… for two letter lnaguage codes only
fix(mosip#656): Resident demographic data are not rendered in requested language
…display AID screen when we close the otp screen
…e recent one, when IDP portal QRCode is scanned.
…ich is recently added.
…ich is recently added.
…ich is recently added.
fix(mosip#490): [Vijay] show the same binded VC only once which is the recent one, when IDP portal QRCode is scanned.
Merge 0.9 FaceSDK fixes into the develop
…display AID screen when we close the otp screen
… for two letter lnaguage codes only
…and store vc data on file system Issue Link: mosip#618
…e name to follow convention
Update android-custom-build.yml
chore(mosip#696): Fix compile errors on windows machine due to Tuvali's incorrect build scripts for windows machine
…and store vc data on file system Issue Link: mosip#618
…ame to follow convention
…s in node_modules
…ice' to 'ENOSPC' while checking disk full error When writing to storage fails, this error 'write failed: ENOSPC (No space left on device)' is thrown by react-native-mmkv-storage & react-native-fs. This changes were made as error code (ENOSPC) has less chances of modification in the latest versions of library we use. Issue Link: https://mosip.atlassian.net/browse/INJI-42
…er dismissing saving failed overlay in MyVcs screen Issue Link: https://mosip.atlassian.net/browse/INJI-42
…or code Issue Link: https://mosip.atlassian.net/browse/INJI-42 Co-authored-by: null <16505295+bhargavi@users.noreply.github.com>
…ctivation status into separate components Issue Link: https://mosip.atlassian.net/browse/INJI-42
…ified & verified activation details into separate components Issue Link: https://mosip.atlassian.net/browse/INJI-42
Reason for adding BLUETOOTH_{SCAN,CONNECT,ADVERTISE} - enables Android12(API level31 & above) devices to scan for BLE peripherals ref: https://developer.android.com/guide/topics/connectivity/bluetooth/permissions#declare-android12-or-higher without this changeset, an exception is thrown - this permission was added in API level 31, hence bumped up compileSdkVersion Co-authored-by: Alka Prasad <prasadalka1998@gmail.com>
fix(INJI-39): add Bluetooth permissions permission for Android12 and bump up compileSdkVersion [ develop ]
feat(INJI-42): Handle database / disk full error
…#725) * Test update readme for read access Signed-off-by: adityankannan-tw <109274996+adityankannan-tw@users.noreply.github.com> * iOS workflow added * iOS slack webhook added * Add a workflow file to build app for every push * Add empty debug keystore file to populate it * Add empty debug keystore file to populate it * fastlane match file added * modify api_key duration * Remove keystore exemption from git ignore * Check for debug keystore file in app directory * Give permission for keystore file to access it * Give permission for keystore file to access it * Print the env variables for keystore * Use same password for both store and key and build the app * Use same password for both and generate in app and build the app * Print debug keystore path and debug it * Print debug keystore path and debug it in fastfile * Export from the current folder and remove sudo * Generate release keystore and build the app * Generate release keystore and build the app try 2 * Generate release keystore and build the app try 3 * Add encoded api key * fastlane match password added * fastlane match key added * Match file env modified * set keystore env for specific tasks and build the app * set keystore env for specific tasks and build the app try 2 * set keystore env for specific tasks and build the app try 3 * set keystore env for specific tasks and build the app try 4 * set keystore env for specific tasks and build the app try 5 * bumping version * create a env file to store env variables and build the app * create a env file in fastlane and load it to build the app * create a env file in fastlane and load it to build the app try 2 * app id added * signing identities added * Pass env from workflow to fastfile and build * Build app in workflow file only * Update the version code in build.gradle and build the app * Update the version code in build.gradle and confirm changes by logging * Update the version code in build.gradle and confirm changes by logging 2 * Double check the version code changes and build the app * Add logs to see version code is changes or not * Add logs to see version code is changes or not try 2 * Add logs to see version code is changes or not try 3 * Add logs to see version code is changes and give execute permission * Build app without exporting the keystore * Build app without exporting the keystore and bump version * Build app by exporting the keystore in a task * Build the app without fastlane * unlock keychain key added * fastfile changes * config modified * xcode proj config added * xcode proj config added * fastfile config added * fastfile config added * modified cert * Fastfile config added * updated key to test workflow * Fastfile config updated * changed to manual match of provisioning profile * Check for git tag * Check for git tag and echo it * Check for git tag using try catch * Check for git tag and print it * Add a tag and try to print it * Add a tag and try to run the task * Add a tag and try to run the task try 2 * Change keystore path and build the app * Change keystore path in build.gradle and build the app * fastfile configured * match modified * match modified * Clean up the code base * Clean up the code base * Clean up the code base and give permission * testers added * Internal testers group * Trigger on workflow push * fastfile changes for testers * fastfile changes for testers * fastfile changes for testers * fastfile changes for testers * fastfile changes for testers * Add a PR trigger for ci-publish * Add a env for keystore job * Added actual env for testers * Add a env for keystore job and export job * Adjust env variables for jobs * Make env as global * Refactor the code base and clear files * [Dhivya|Adityan] feat(#INJI-29|31)[Android][iOS] PR trigger and automate build using fastlane and push iOS build to test flight * [Dhivya|Adityan] refactor(#INJI-29|31)[Android][iOS] Change the backend url and add comments and rename apk output * [Dhivya|Adityan] refactor(#INJI-29|31)[Android][iOS] Change the workflow name --------- Signed-off-by: adityankannan-tw <109274996+adityankannan-tw@users.noreply.github.com> Co-authored-by: MOSIP <mosip@MOSIPs-MacBook-Air.local> Co-authored-by: Adityan Kannan <adityankannan@Adityans-MacBook-Pro.local> Co-authored-by: Dhivya <dhivya.v@thoughtworks.com>
* Update android-custom-build.yml * Test update readme for read access Signed-off-by: adityankannan-tw <109274996+adityankannan-tw@users.noreply.github.com> * iOS workflow added * iOS slack webhook added * Add a workflow file to build app for every push * Add empty debug keystore file to populate it * Add empty debug keystore file to populate it * fastlane match file added * modify api_key duration * Remove keystore exemption from git ignore * Check for debug keystore file in app directory * Give permission for keystore file to access it * Give permission for keystore file to access it * Print the env variables for keystore * Use same password for both store and key and build the app * Use same password for both and generate in app and build the app * Print debug keystore path and debug it * Print debug keystore path and debug it in fastfile * Export from the current folder and remove sudo * Generate release keystore and build the app * Generate release keystore and build the app try 2 * Generate release keystore and build the app try 3 * Add encoded api key * fastlane match password added * fastlane match key added * Match file env modified * set keystore env for specific tasks and build the app * set keystore env for specific tasks and build the app try 2 * set keystore env for specific tasks and build the app try 3 * set keystore env for specific tasks and build the app try 4 * set keystore env for specific tasks and build the app try 5 * bumping version * create a env file to store env variables and build the app * create a env file in fastlane and load it to build the app * create a env file in fastlane and load it to build the app try 2 * app id added * signing identities added * Pass env from workflow to fastfile and build * Build app in workflow file only * Update the version code in build.gradle and build the app * Update the version code in build.gradle and confirm changes by logging * Update the version code in build.gradle and confirm changes by logging 2 * Double check the version code changes and build the app * Add logs to see version code is changes or not * Add logs to see version code is changes or not try 2 * Add logs to see version code is changes or not try 3 * Add logs to see version code is changes and give execute permission * Build app without exporting the keystore * Build app without exporting the keystore and bump version * Build app by exporting the keystore in a task * Build the app without fastlane * unlock keychain key added * fastfile changes * config modified * xcode proj config added * xcode proj config added * fastfile config added * fastfile config added * modified cert * Fastfile config added * updated key to test workflow * Fastfile config updated * changed to manual match of provisioning profile * Check for git tag * Check for git tag and echo it * Check for git tag using try catch * Check for git tag and print it * Add a tag and try to print it * Add a tag and try to run the task * Add a tag and try to run the task try 2 * Change keystore path and build the app * Change keystore path in build.gradle and build the app * fastfile configured * match modified * match modified * Clean up the code base * Clean up the code base * Clean up the code base and give permission * testers added * Internal testers group * Trigger on workflow push * fastfile changes for testers * fastfile changes for testers * fastfile changes for testers * fastfile changes for testers * fastfile changes for testers * Add a PR trigger for ci-publish * Add a env for keystore job * Added actual env for testers * Add a env for keystore job and export job * Adjust env variables for jobs * Make env as global * Refactor the code base and clear files * [Dhivya|Adityan] feat(#INJI-29|31)[Android][iOS] PR trigger and automate build using fastlane and push iOS build to test flight * [Dhivya|Adityan] refactor(#INJI-29|31)[Android][iOS] Change the backend url and add comments and rename apk output * [Dhivya|Adityan] refactor(#INJI-29|31)[Android][iOS] Change the workflow name * configure macos runner * modify command for fastlane --------- Signed-off-by: adityankannan-tw <109274996+adityankannan-tw@users.noreply.github.com> Co-authored-by: Keshav Mishra <chandrakeshavmishra@gmail.com> Co-authored-by: Monobikash Das <43202165+MonobikashDas@users.noreply.github.com> Co-authored-by: adityankannan-tw <109274996+adityankannan-tw@users.noreply.github.com> Co-authored-by: MOSIP <mosip@MOSIPs-MacBook-Air.local> Co-authored-by: Adityan Kannan <adityankannan@Adityans-MacBook-Pro.local> Co-authored-by: adityankannan-tw <adityan.kannan@thoughtworks.com>
[Release 30-05-2023] UI improvements, device specific issue fixes, permissions enhancements & Storage Optimisation
INJI-29 iOS build fixes to build from the command line.
Add iOS test flight testing groups in the github workflow
…s, device specific issue fixes, permissions enhancements & Storage Optimisation
ravikp
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging develop branch to 0.9 branch should be good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancements :
#618 - Optimisation of Save VC flow
INJI-80 - Display all the binded VC on the VC share screen
INJI-71 - [Both IOS & Android] Pass error codes on Error
INJI-29 - iOS build automation
Fixes :
#675 - IOS - App is getting crashed when we try to go back from the OTP screen while genrating VID from AID
#656 - Resident demographic data are not rendered in requested language
#223 - In inji app still labels and button remained in english even after language switch
INJI-39 - Android - Specific devices are not connecting for sharing
INJI-34 - RTL is not handled in Inji app
INJI-36 - RTL is not handled in Inji app
INJI-42 - Handle database or diskfull error