-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning on Corrade #53
Comments
Hmm. I did't encounter this warning myself -- reminds me of those dreaded warnings about DLL interface for STL classes that MSVC likes to warn about. Looking at the Travis build, it prints two warnings but these are completely different and unrelated to this. Checked also the iOS build and my local Linux Clang/libc++ build, but no warning there either. Anything special you have enabled? Debug build or Release? I see this is a static build? Looking at it, it seems to be caused by a particular STL implementation (libc++), where it has some attributes that trigger this. But no idea why just here and not elsewhere. As a completely random idea, could you try compiling with this patch applied? diff --git a/src/Corrade/Utility/VisibilityMacros.h b/src/Corrade/Utility/VisibilityMacros.h
index e741f559..16fb1a73 100644
--- a/src/Corrade/Utility/VisibilityMacros.h
+++ b/src/Corrade/Utility/VisibilityMacros.h
@@ -50,13 +50,11 @@
#endif
/** @hideinitializer
* @brief Public symbol in a static library
*/
-#ifdef CORRADE_TARGET_WINDOWS
#define CORRADE_VISIBILITY_STATIC
-#else
-#define CORRADE_VISIBILITY_STATIC __attribute__ ((visibility ("default")))
-#endif
/** @hideinitializer
@brief Local symbol |
Hmm. I'm getting a similar warning on Travis when compiling Magnum:
If you would have a chance testing with the above patch, that would be great 👍 I only have macOS on Travis and doing any trial-and-error testing there is fairly time consuming ;) |
I’ll give it a shot tomorrow, I was buried very deep in message pumps, interrupt requests, signal handlers and all that fun stuff last few days, just now looking around. |
Hi, Just pulled latest from master, and still get a LOT of those visibility warnings:
|
Well, I didn't apply the above patch because I was not sure if it fixes anything for you ;) Could you try applying it locally and building again, to see if it makes any difference? Thanks! For the |
Just tried it, basically what you're doing is defining the Does not seem to do anything, no change. |
The stable release is out, so we can experiment again :) I googled around and this popped up: avast/retdec@0f90931. Could you try building the whole project (maybe Corrade as well) with |
Should be fixed in 7ae9031. |
Corrade build on OSX results in this somewhat annoying linker warning. This warning has been around since I first started using Corrade.
The warning shows up in both Eclipse (Unix Makefile) and Xcode builds.
I've haven't been bothered enough to try to track it down, but just reporting it here if anyone has a quick fix.
This warning does not seem to effect functionality or usage, it's just kind of annoying to see the warning on each build.
The text was updated successfully, but these errors were encountered: