Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[appveyor] Added vs2017 to the build images #34
Hmm -- there is something suspicious about MSVC 2017. Both 2015 and 2017 report themselves as "version 19" or "version 14", depending on where one looks:
while 2017 says:
The thing is that my CMake buildscripts are enabling some ugly workarounds for 2015 ("14") which I hope are resolved with 2017 ("15"), but now I have no way to distinguish between them, as there is no significant version difference. I need to investigate what's going on here.
Concerning this issue - I've tried my best to detect installed msvc version with vswhere but the current state of the things and Microsoft/vswhere#62 makes it's almost unusable with legacy Visual Studio 2015 image. However, the good news is: Visual Studio 2017 image contains both legacy and newer build tools and with the minor workarounds, it is possible to select correct vcvarsall.bat and such. Maybe even parametrise from the appveyor.yml and add x86 builds alongside.
After some investigation I found out that MSVC 2017 presents itself as version
The AppVeyor config was merged with some modifications as 3c2ded3 -- hope that's okay. I'll now proceed with integrating your changes in the other projects. Thanks a lot for this!