Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VS Code release #14

Merged
merged 2 commits into from
Mar 21, 2021
Merged

Fix VS Code release #14

merged 2 commits into from
Mar 21, 2021

Conversation

samestep
Copy link
Collaborator

@samestep samestep commented Mar 21, 2021

While #13 fixed the crates.io release for version 0.1.1, trying to run vsce publish from within editors/code now gives this error:

 ERROR  Images in README.md must come from an HTTPS source: /editors/code/hello.png

This PR attempts to fix that for version 0.1.2, now that I know that I can apparently run vsce package somewhat analogously to cargo publish --dry-run.

When I published v0.0.1 of the VS Code extension, I used this sequence of commands:

cd editors/code
npm install
vsce publish --baseImagesUrl='https://github.com/samestep/quench/blob/v0.1.0/editors/code'

The specific --baseImagesUrl I passed is incorrect, but it does seem to be necessary since I use relative links in editors/code/README.md. However, apparently the change to editors/code/README.md actually broke this approach, because currently, the above error message even occurs when passing --baseImagesUrl. This PR corrects the problem by changing the hello.png link back to the way it was, and also fixes the link for Quench itself.

The sequence of commands for publishing version 0.1.2 of the VS Code extension should look like this:

cd editors/code
npm install
npm run compile
vsce publish --baseImagesUrl='https://raw.githubusercontent.com/samestep/quench/v0.1.2/editors/code'

@samestep samestep marked this pull request as ready for review March 21, 2021 01:42
@samestep samestep merged commit 7ab0668 into main Mar 21, 2021
@samestep samestep deleted the fix-vsce-publish branch March 21, 2021 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant