Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop node 8 support #516

Merged
merged 4 commits into from
May 5, 2021
Merged

Drop node 8 support #516

merged 4 commits into from
May 5, 2021

Conversation

motdotla
Copy link
Owner

@motdotla motdotla commented May 5, 2021

No description provided.

This was referenced May 5, 2021
Copy link
Collaborator

@jcblw jcblw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the cleanup!

@motdotla motdotla merged commit db30e1e into master May 5, 2021
@motdotla motdotla deleted the drop-node-8-support branch May 5, 2021 02:37
@MichaelDeBoey
Copy link
Contributor

MichaelDeBoey commented May 5, 2021

@motdotla This should have been a breaking change with a major version release

@motdotla
Copy link
Owner Author

motdotla commented May 5, 2021

@MichaelDeBoey you are right. I will bump to 9.0.0 shortly to rectify as best as possible. We'll still leave 8.3.0 onward as not supporting 8 despite the mistake - so as not to yank those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants