Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ghq.completeUser config to disable user completion of `ghq get` #118

Merged
merged 1 commit into from Apr 26, 2019

Conversation

Projects
None yet
2 participants
@k0kubun
Copy link
Contributor

commented Mar 27, 2019

Problem

Prior to v0.8.0 #81, I had used ghq get repo to clone repo/repo. The behavior was convenient for cloning some repositories like git/git, ruby/ruby, rails/rails, peco/peco, vim/vim, haml/haml, bundler/bundler, rack/rack, etc., as described in #14.

I'd like to use the feature again because I usually clone all of my repositories at once and rarely clone my repository with ghq get. Also I often get confused by trying to use the old behavior, even after 2 years.

Solution

I'd like to introduce a git config to resurrect the original behavior:

[ghq]
  completeUser = false

With this config, ghq get repo clones repo/repo. By default it's considered as true and this PR is backward-compatible.

Note that completeuser = false also works by the nature of git config.

@Songmu

This comment has been minimized.

Copy link
Collaborator

commented Apr 26, 2019

Actually I also liked the previous behavior, but it is only a matter of preference, so I think it is a good solution to make it configurable.

@Songmu Songmu merged commit d0b6286 into motemen:master Apr 26, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@k0kubun k0kubun deleted the k0kubun:disable-user-completion branch Apr 26, 2019

Songmu added a commit that referenced this pull request Apr 27, 2019

Checking in changes prior to tagging of version v0.10.0
## [v0.10.0](v0.9.0...v0.10.0) (2019-04-27)

* drop mitchellh/go-homedir dependency [#122](#122) ([Songmu](https://github.com/Songmu))
* introduce Go Modules and adjust releng files [#121](#121) ([Songmu](https://github.com/Songmu))
* Add a dummy CVS backend to recognize and skip CVS working directories [#115](#115) ([knu](https://github.com/knu))
* add -l option on get command which immediately look after get [#112](#112) ([kuboon](https://github.com/kuboon))
* add support for Fossil SCM [#98](#98) ([motemen](https://github.com/motemen))
* Use parsed username also with ssh for Git [#101](#101) ([jjv](https://github.com/jjv))
* Add ghq.completeUser config to disable user completion of `ghq get` [#118](#118) ([k0kubun](https://github.com/k0kubun))
* ghq get --vcs=<vcs> [#72](#72) ([motemen](https://github.com/motemen))
* warn if executable was not found when RunCommand [#70](#70) ([motemen](https://github.com/motemen))
* support `meta name="go-import"` to detect Go repository [#120](#120) ([Songmu](https://github.com/Songmu))
* support refs which start with URL Authority in ghq get [#119](#119) ([Songmu](https://github.com/Songmu))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.