Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, I update the logic in
translate()
to allow optional arguments.I decided to open this pull request after I ran into a ui file compilation difference:
Notice how the first compilation with
pyside-5.15.4
returns translate with 3 arguments instead of 4.When we eventually use
QtCompat.translate()
we run into the following error:Now
translate("MainWindow", u"MainWindow", None)
will work sincen
defaults to-1
.