Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debugging informative log statement for a common error #2509

Merged
merged 3 commits into from
Feb 25, 2021

Conversation

PeterMitrano
Copy link
Contributor

Description

If the user calls setJointValueTarget with the wrong number of joint values, it just returns false without providing any information as to what went wrong. Personally when something in moveit goes wrong the first thing I do is turn on debug logging so this would help in that case.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link
Contributor

@simonschmeisser simonschmeisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

not sure if you want to include the group name as well?

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #2509 (1eadf26) into master (4788419) will increase coverage by 3.57%.
The diff coverage is 97.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2509      +/-   ##
==========================================
+ Coverage   56.68%   60.24%   +3.57%     
==========================================
  Files         281      351      +70     
  Lines       25455    26475    +1020     
==========================================
+ Hits        14426    15948    +1522     
+ Misses      11029    10527     -502     
Impacted Files Coverage Δ
...lude/moveit/collision_detection/collision_common.h 93.94% <ø> (+13.94%) ⬆️
...sion_detection_bullet/src/collision_env_bullet.cpp 78.38% <0.00%> (-0.44%) ⬇️
.../moveit/collision_detection_fcl/collision_common.h 100.00% <ø> (+11.30%) ⬆️
.../collision_detection_fcl/src/collision_env_fcl.cpp 88.42% <0.00%> (-0.23%) ⬇️
...on_distance_field/collision_distance_field_types.h 49.16% <ø> (-0.84%) ⬇️
...del/include/moveit/robot_model/joint_model_group.h 100.00% <ø> (ø)
moveit_core/robot_state/src/robot_state.cpp 50.00% <0.00%> (+3.87%) ⬆️
...rial_motion_planner/src/velocity_profile_atrap.cpp 100.00% <ø> (ø)
...pilz_industrial_motion_planner_testutils/basecmd.h 100.00% <ø> (ø)
..._motion_planner_testutils/cartesianconfiguration.h 44.45% <ø> (ø)
... and 372 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4788419...dc5301d. Read the comment docs.

@PeterMitrano
Copy link
Contributor Author

sure, why not. I've added dded the group name. Thanks for the speedy approve!

@jschleicher jschleicher merged commit 34b2356 into moveit:master Feb 25, 2021
@tylerjw tylerjw mentioned this pull request Apr 9, 2021
tylerjw pushed a commit to tylerjw/moveit that referenced this pull request Apr 29, 2021
add debugging informative log statement for a common error

Co-authored-by: Peter Mitrano <pmitrano@armstorm>
@tylerjw tylerjw mentioned this pull request Apr 29, 2021
tylerjw pushed a commit to tylerjw/moveit that referenced this pull request May 3, 2021
add debugging informative log statement for a common error

Co-authored-by: Peter Mitrano <pmitrano@armstorm>
tylerjw pushed a commit that referenced this pull request May 3, 2021
add debugging informative log statement for a common error

Co-authored-by: Peter Mitrano <pmitrano@armstorm>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants