-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when including eigenpy.hpp
#195
Comments
Hi @acxz, Note: MoveIt is not yet using CMake targets but pkg-config. |
Hello @wxmerkt thx for responding Just found out that there is a As for numpy headers I do have those installed. |
@acxz: The release has a few patches applied on top of this repository for noetic to fix some CMake module issues, cf. https://github.com/ipab-slmc/eigenpy_catkin-release/tree/patches/release/noetic/eigenpy Any questions, please let me know |
Is there any reason why these patches are not merged into this repository? Or rather this repo: https://github.com/jrl-umi3218/jrl-cmakemodules/tree/master? Also seems like I am still getting the error even when using the release/noetic/eigenpy release. Looks like I need to dig a bit deeper. |
@acxz : on Arch, you can use directly https://aur.archlinux.org/packages/eigenpy/ |
Hey @nim65s! Thx for responding That is actually how I got the error. So I was like hey maybe I should use the catkin package, but then looking at the latest moveit release they are using the system eigenpy, which does not work. It does however work with pkgconfig instead of find_package. |
The above mentioned PR resolves the issue for me. From what I understand, I'll keep this issue open since it seems like this points to a deeper issue in eigenpy's CMake configuration. @wxmerkt in the latest release in moveit-ros-planning-interface they are using the system eigenpy not the ros eigenpy, therefore I did not need ros-noetic-eigenpy. Although for what it's worth ros-eigenpy (with those patches) did not resolve the issue for me either. |
The cmake packaging of EigenPy is working and it is tested on the CI. Could you provide a tiny example to allow to reproduce it? |
@jcarpent sounds good, yeah maybe I am messing up somewhere locally on my end. |
Woops, I didn't meant to close this. @acxz: can you try moveit/moveit@24031ff ? |
Just tried and it works, I think it is safe to close this since the issue is in the moveit repo. Thx for quick response and the amazing software! |
fix stack-of-tasks/eigenpy#195 Since moveit#1737, eigenpy is found using find_package, so we can get all required informations to find headers and link to shared objects with a target_link_libraries to the eigenpy::eigenpy imported CMake target.
To clarify: The EigenPy packaged via ROS is the EigenPy in this repository, plus the fixes to the cmake module linked above. MoveIt uses EigenPy via ROS that includes these fixes. We spent a long time (a process that took weeks and coordination) to ensure backward compatibility when the PkgConfig/CMake packaging changed, so it should all still work. My latest checks on Melodic work, and so does the CI that tests these. I will follow up on the MoveIt PR. |
fix stack-of-tasks/eigenpy#195 Since #1737, eigenpy is found using find_package, so we can get all required informations to find headers and link to shared objects with a target_link_libraries to the eigenpy::eigenpy imported CMake target.
fix stack-of-tasks/eigenpy#195 Since moveit#1737, eigenpy is found using find_package, so we can get all required informations to find headers and link to shared objects with a target_link_libraries to the eigenpy::eigenpy imported CMake target.
fix stack-of-tasks/eigenpy#195 Since moveit#1737, eigenpy is found using find_package, so we can get all required informations to find headers and link to shared objects with a target_link_libraries to the eigenpy::eigenpy imported CMake target.
fix stack-of-tasks/eigenpy#195 Since moveit#1737, eigenpy is found using find_package, so we can get all required informations to find headers and link to shared objects with a target_link_libraries to the eigenpy::eigenpy imported CMake target.
fix stack-of-tasks/eigenpy#195 Since moveit#1737, eigenpy is found using find_package, so we can get all required informations to find headers and link to shared objects with a target_link_libraries to the eigenpy::eigenpy imported CMake target. (cherry picked from commit 81e64b9)
fix stack-of-tasks/eigenpy#195 Since moveit#1737, eigenpy is found using find_package, so we can get all required informations to find headers and link to shared objects with a target_link_libraries to the eigenpy::eigenpy imported CMake target.
fix stack-of-tasks/eigenpy#195 Since #1737, eigenpy is found using find_package, so we can get all required informations to find headers and link to shared objects with a target_link_libraries to the eigenpy::eigenpy imported CMake target.
The text was updated successfully, but these errors were encountered: