Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify log names #2720

Merged
merged 6 commits into from
Mar 15, 2024
Merged

Unify log names #2720

merged 6 commits into from
Mar 15, 2024

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented Mar 1, 2024

Description

Resolve #1926

This PR updates all lognames to the pattern proposed in this comment

moveit.<package>.<context>.<optional detail>

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sjahr sjahr requested a review from henningkayser March 1, 2024 19:27
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 44.68085% with 104 lines in your changes are missing coverage. Please review.

Project coverage is 42.64%. Comparing base (d962501) to head (56e297d).
Report is 20 commits behind head on main.

❗ Current head 56e297d differs from pull request most recent head c6f2635. Consider uploading reports for the commit c6f2635 to get more accurate results

Files Patch % Lines
...e/include/moveit/kinematics_base/kinematics_base.h 0.00% 3 Missing ⚠️
.../move_group_interface/src/move_group_interface.cpp 0.00% 3 Missing ⚠️
...ng_scene_rviz_plugin/src/background_processing.cpp 0.00% 3 Missing ⚠️
..._ros/robot_interaction/src/interaction_handler.cpp 0.00% 2 Missing ⚠️
...ros/warehouse/src/planning_scene_world_storage.cpp 0.00% 2 Missing ⚠️
...s/warehouse/src/trajectory_constraints_storage.cpp 0.00% 2 Missing ⚠️
..._detection/src/allvalid/collision_env_allvalid.cpp 0.00% 1 Missing ⚠️
..._core/collision_detection/src/collision_common.cpp 0.00% 1 Missing ⚠️
...eit_core/collision_detection/src/collision_env.cpp 0.00% 1 Missing ⚠️
..._core/collision_detection/src/collision_matrix.cpp 0.00% 1 Missing ⚠️
... and 85 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2720      +/-   ##
==========================================
- Coverage   50.74%   42.64%   -8.09%     
==========================================
  Files         392      692     +300     
  Lines       32553    56311   +23758     
  Branches        0     7271    +7271     
==========================================
+ Hits        16517    24011    +7494     
- Misses      16036    32136   +16100     
- Partials        0      164     +164     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Abishalini Sivaraman <abi.gpuram@gmail.com>
@sjahr sjahr requested a review from Abishalini March 11, 2024 09:15
@sjahr sjahr enabled auto-merge (squash) March 12, 2024 12:56
@sjahr sjahr disabled auto-merge March 12, 2024 12:56
@sjahr sjahr enabled auto-merge (squash) March 13, 2024 15:20
@sjahr sjahr disabled auto-merge March 13, 2024 15:20
@henningkayser henningkayser merged commit f06f38b into moveit:main Mar 15, 2024
5 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate and document ways for using logging namespaces
3 participants