Small fixes to flaky MoveIt Servo integration tests #2962
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've been seeing servo integration tests flake every now and then, and found it improved when removing the node before trying to cancel the executor and join its spinning thread.
I also changed some incorrect
/
characters in the integration test launch files' static transform publisher. We were failing to get a proper state from the planning scene because the virtual joint was flagged as missing.Checklist