Port moveit ros visualization #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JafarAbdi
force-pushed
the
pr-moveit_ros_visualization
branch
4 times, most recently
from
3140603
to
49b6049
Compare
JafarAbdi
commented
Jan 28, 2020
moveit_ros/visualization/robot_state_rviz_plugin/src/robot_state_display.cpp
Outdated
Show resolved
Hide resolved
JafarAbdi
changed the title
...lanning_scene_rviz_plugin/include/moveit/planning_scene_rviz_plugin/planning_scene_display.h
Show resolved
Hide resolved
...lanning_scene_rviz_plugin/include/moveit/planning_scene_rviz_plugin/planning_scene_display.h
Outdated
Show resolved
Hide resolved
moveit_ros/visualization/planning_scene_rviz_plugin/src/planning_scene_display.cpp
Show resolved
Hide resolved
| @@ -575,7 +580,9 @@ void PlanningSceneDisplay::onEnable() | |||
| { | |||
| Display::onEnable(); | |||
|
|
|||
| addBackgroundJob(boost::bind(&PlanningSceneDisplay::loadRobotModel, this), "loadRobotModel"); | |||
| addBackgroundJob( | |||
| boost::bind(&PlanningSceneDisplay::loadRobotModel, this, rclcpp::Node::make_shared("planning_scene_display")), | |||
There was a problem hiding this comment.
Shouldn't we just pass the node or create a subnode?
There was a problem hiding this comment.
Not sure which one is better, what do you think .?
moveit_ros/visualization/robot_state_rviz_plugin/src/robot_state_display.cpp
Outdated
Show resolved
Hide resolved
...ion/rviz_plugin_render_tools/include/moveit/rviz_plugin_render_tools/planning_link_updater.h
Outdated
Show resolved
Hide resolved
moveit_ros/visualization/rviz_plugin_render_tools/include/ogre_helpers/mesh_shape.hpp
Show resolved
Hide resolved
|
Building this, I am able to see the RobotState Display but not the Planning scene. When I try to load the RobotState Display, I get the following error. Is that expected? Regarding your question about the other two displays: Trajectory would be useful to have if it isn't too much work. The Motion planning one would be a huge win but it depends on a ton of other pieces so it would likely need to wait until after at least move_group. |
|
I believe you can also remove the |
mlautman
reviewed
Jan 31, 2020
...lanning_scene_rviz_plugin/include/moveit/planning_scene_rviz_plugin/planning_scene_display.h
Outdated
Show resolved
Hide resolved
moveit_ros/visualization/planning_scene_rviz_plugin/src/planning_scene_display.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/visualization/planning_scene_rviz_plugin/src/planning_scene_display.cpp
Outdated
Show resolved
Hide resolved
JafarAbdi
force-pushed
the
pr-moveit_ros_visualization
branch
from
ea2e35c
to
6371c7b
Compare
moveit_ros/visualization/rviz_plugin_render_tools/include/ogre_helpers/mesh_shape.hpp
Show resolved
Hide resolved
JafarAbdi
force-pushed
the
pr-moveit_ros_visualization
branch
from
e10561b
to
c05f606
Compare
henningkayser
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on common_planning_interface_objects and planning_scene_monitor
rviz_plugin_render_tools and robot_state_rviz_plugin are ported the remaining one for the beta release is planning_scene_rviz_plugin (should we port the remaining two .?)
TODO:
Checklist