Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generate_parameter_library to load srv kinematics parameters #1674

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

Abishalini
Copy link
Contributor

@Abishalini Abishalini commented Oct 31, 2022

Description

Use generate_parameter_library to load srv kinematics parameters

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@Abishalini Abishalini marked this pull request as ready for review October 31, 2022 05:15
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 51.07% // Head: 51.07% // No change to project coverage 👍

Coverage data is based on head (6c6f024) compared to base (bd9a9e8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1674   +/-   ##
=======================================
  Coverage   51.07%   51.07%           
=======================================
  Files         381      381           
  Lines       31743    31743           
=======================================
  Hits        16208    16208           
  Misses      15535    15535           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tylerjw tylerjw merged commit 28ba7fc into moveit:main Oct 31, 2022
@Abishalini Abishalini deleted the srv_kinematics_parameters branch November 1, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants