-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port parallel planning reviews from MoveIt1 #1699
Conversation
Codecov ReportBase: 50.97% // Head: 50.97% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1699 +/- ##
=======================================
Coverage 50.97% 50.97%
=======================================
Files 378 378
Lines 31649 31649
=======================================
Hits 16131 16131
Misses 15518 15518 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only two nitpicks:
moveit_ros/planning/moveit_cpp/include/moveit/moveit_cpp/moveit_cpp.h
Outdated
Show resolved
Hide resolved
@@ -39,6 +39,7 @@ | |||
|
|||
#include <algorithm> | |||
#include <moveit/planning_interface/planning_response.h> | |||
#include <mutex> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is that required now (and not before)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It build before, probably because we're lucky and the required header was included from somewhere else but I think it is nicer to ensure that everything is included.
…t_cpp.h Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com>
Description
This PR ports addressed reviews from @rhaschke to MoveIt2. Most importantly,
bool generatePlan(...)
becomes const again 👍Checklist