Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -Wunused-function #1754

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Add -Wunused-function #1754

merged 1 commit into from
Nov 22, 2022

Conversation

ChrisThrasher
Copy link
Contributor

Description

This function is regarded as unused in some translation units because it's marked static but not used in every single TU where it's included. static free functions are typically only used within a single TU as a way to tell the compiler that no other TUs will link to this function.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice little cleanup, thank you!

@tylerjw tylerjw added the backport-humble Mergify label that triggers a PR backport to Humble label Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 50.95% // Head: 50.95% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (af96196) compared to base (acc64da).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1754      +/-   ##
==========================================
- Coverage   50.95%   50.95%   -0.00%     
==========================================
  Files         378      378              
  Lines       31659    31671      +12     
==========================================
+ Hits        16130    16136       +6     
- Misses      15529    15535       +6     
Impacted Files Coverage Δ
...bullet/src/bullet_integration/ros_bullet_utils.cpp 65.00% <0.00%> (-27.85%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 45.21% <0.00%> (-0.43%) ⬇️
moveit_ros/moveit_servo/src/pose_tracking.cpp 77.26% <0.00%> (+0.48%) ⬆️
moveit_ros/moveit_servo/src/servo_calcs.cpp 67.43% <0.00%> (+1.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tylerjw tylerjw merged commit ed9c331 into moveit:main Nov 22, 2022
@ChrisThrasher ChrisThrasher deleted the Wunused-function branch November 22, 2022 19:58
mergify bot pushed a commit that referenced this pull request Nov 22, 2022
(cherry picked from commit ed9c331)
tylerjw pushed a commit that referenced this pull request Nov 22, 2022
(cherry picked from commit ed9c331)

Co-authored-by: Chris Thrasher <chrisjthrasher@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Mergify label that triggers a PR backport to Humble
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants