Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile on ROS2 Foxy #227

Merged
merged 19 commits into from
Aug 11, 2020
Merged

Compile on ROS2 Foxy #227

merged 19 commits into from
Aug 11, 2020

Conversation

henningkayser
Copy link
Member

Once #226 is merged, I will branch off foxy and retarget this PR, generate docker images and trigger CI.

@codecov

This comment has been minimized.

Copy link
Contributor

@AdamPettinger AdamPettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pulled the latest version here and successfully built/tested using the newest moveit2.repos in a blank workspace. Looks good to me

Copy link
Contributor

@JafarAbdi JafarAbdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor nits. I will now test this on foxy and report back if I have any issues making this work.

@henningkayser
Copy link
Member Author

Travis succeeded, Github just doesn't get updated (https://travis-ci.com/github/ros-planning/moveit2/builds/179287457)

@henningkayser
Copy link
Member Author

Cleaned up redundant commits

@henningkayser henningkayser merged commit 1988d35 into moveit:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants