Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foxy prep fixes #226

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Foxy prep fixes #226

merged 1 commit into from
Jun 25, 2020

Conversation

henningkayser
Copy link
Member

General fixes that are required for Foxy to build. Since these are very generic, I think they should be merged into master.

@henningkayser henningkayser changed the title Foxy prep Foxy prep fixes Jun 24, 2020
henningkayser
henningkayser commented Jun 24, 2020
View reviewed changes
moveit_core/constraint_samplers/test/pr2_arm_kinematics_plugin.h Outdated
@@ -84,6 +84,8 @@ class PR2ArmIKSolver : public KDL::ChainIkSolverPos

~PR2ArmIKSolver() override{};

void updateInternalDataStructures() override;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason this function was deleted in (https://github.com/ros-planning/moveit2/pull/60/files#diff-8404d089489122c76cd63a908826c88eL90) even though it overrides a virtual function. Not sure why this didn't complain with eloquent.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this since ros-eloquent-orocos-kdl is at 3.2.1 which doesn't include this. @clalancette are there plans for making another eloquent release?

tylerjw
tylerjw approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@v4hn
Copy link
Contributor

v4hn commented Jun 24, 2020

Could you please keep an eye on and add relevant changes to the moveit repo as well?
I guess at least the regex component is missing here too.

@henningkayser henningkayser mentioned this pull request Jun 24, 2020
Merged
@henningkayser henningkayser mentioned this pull request Jun 25, 2020
Merged
@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #226 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
- Coverage   47.43%   47.35%   -0.08%     
==========================================
  Files         143      143              
  Lines       13347    13347              
==========================================
- Hits         6331     6321      -10     
- Misses       7016     7026      +10
Impacted Files Coverage Δ
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 66.22% <0.00%> (-4.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2ff4b9...4a36545. Read the comment docs.

@henningkayser henningkayser merged commit 9382ede into moveit:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerjw tylerjw tylerjw approved these changes

@JafarAbdi JafarAbdi Awaiting requested review from JafarAbdi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@henningkayser @v4hn @tylerjw