-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a private node to the interactive marker display #342
Add a private node to the interactive marker display #342
Conversation
Codecov Report
@@ Coverage Diff @@
## main #342 +/- ##
==========================================
+ Coverage 53.23% 53.24% +0.02%
==========================================
Files 209 209
Lines 18849 18849
==========================================
+ Hits 10033 10035 +2
+ Misses 8816 8814 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the fix is really just affecting a native RViz component I'd vote for filing this as an upstream PR. That way this annoying but harmless issue can be avoided by compiling RViz from source and we don't have to maintain additional third-party source files.
...planning_rviz_plugin/include/moveit/motion_planning_rviz_plugin/interactive_marker_display.h
Outdated
Show resolved
Hide resolved
If a user manually added an interactive marker they will get the native one from RViz, the one here is only used for the interactive marker inside the motion planning display |
Description
A temporary workaround to fix the lag in the motion planning display interactive marker by adding an internal node & executor
Checklist