Add forward_trajectory local solver plugin #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/hybrid_planning #359 +/- ##
========================================================
Coverage 48.00% 48.00%
========================================================
Files 157 157
Lines 14843 14843
========================================================
Hits 7124 7124
Misses 7719 7719 Continue to review full report at Codecov.
|
henningkayser
approved these changes
Feb 17, 2021
|
@henningkayser Seems like a failing moveit_servo test leads to not passing the CI checks. Is that a flaky test? Would rebasing the PR and the feature branch solve the issue? |
Sorry, I somehow didn't notice this. I'll merge your PR and after that you could prepare a rebased feature branch that we can force-push. I'm not sure if the servo issue would be resolved by that though. |
|
@sjahr the failing servo test is flaky. My migration to GitHub Actions PR disables it until we can figure out how to fix it. |
sjahr
added a commit
to sjahr/moveit2
that referenced
this pull request
Apr 16, 2021
sjahr
added a commit
to sjahr/moveit2
that referenced
this pull request
May 4, 2021
sjahr
added a commit
to sjahr/moveit2
that referenced
this pull request
May 4, 2021
sjahr
added a commit
to sjahr/moveit2
that referenced
this pull request
May 9, 2021
henningkayser
pushed a commit
that referenced
this pull request
May 18, 2021
henningkayser
pushed a commit
that referenced
this pull request
May 18, 2021
sjahr
added a commit
to sjahr/moveit2
that referenced
this pull request
Jun 4, 2021
Use ros2_control based joint simulation and remove unnecessary comment Update copyrights Restructure hybrid planning package Fix formatting and add missing time stamp in local solver plugin Remove unnecessary logging and param loading Enable different interfaces between local planner and controller Use JointGroupPositionController as demo hardware controller
sjahr
added a commit
to sjahr/moveit2
that referenced
this pull request
Jun 7, 2021
* Add forward_trajectory local solver plugin (moveit#359) * Use ros2_control based joint simulation and remove unnecessary comment * Update copyrights * Restructure hybrid planning package * Fix formatting and add missing time stamp in local solver plugin * Remove unnecessary logging and param loading * Enable different interfaces between local planner and controller * Use JointGroupPositionController as demo hardware controller
henningkayser
pushed a commit
to henningkayser/moveit2
that referenced
this pull request
Jul 6, 2021
* Add forward_trajectory local solver plugin (moveit#359) * Use ros2_control based joint simulation and remove unnecessary comment * Update copyrights * Restructure hybrid planning package * Fix formatting and add missing time stamp in local solver plugin * Remove unnecessary logging and param loading * Enable different interfaces between local planner and controller * Use JointGroupPositionController as demo hardware controller
sjahr
added a commit
to sjahr/moveit2
that referenced
this pull request
Aug 21, 2021
* Add forward_trajectory local solver plugin (moveit#359) * Use ros2_control based joint simulation and remove unnecessary comment * Update copyrights * Restructure hybrid planning package * Fix formatting and add missing time stamp in local solver plugin * Remove unnecessary logging and param loading * Enable different interfaces between local planner and controller * Use JointGroupPositionController as demo hardware controller
sjahr
added a commit
to sjahr/moveit2
that referenced
this pull request
Sep 28, 2021
* Add forward_trajectory local solver plugin (moveit#359) * Use ros2_control based joint simulation and remove unnecessary comment * Update copyrights * Restructure hybrid planning package * Fix formatting and add missing time stamp in local solver plugin * Remove unnecessary logging and param loading * Enable different interfaces between local planner and controller * Use JointGroupPositionController as demo hardware controller
sjahr
added a commit
to sjahr/moveit2
that referenced
this pull request
Oct 19, 2021
* Add forward_trajectory local solver plugin (moveit#359) * Use ros2_control based joint simulation and remove unnecessary comment * Update copyrights * Restructure hybrid planning package * Fix formatting and add missing time stamp in local solver plugin * Remove unnecessary logging and param loading * Enable different interfaces between local planner and controller * Use JointGroupPositionController as demo hardware controller
sjahr
added a commit
to sjahr/moveit2
that referenced
this pull request
Oct 28, 2021
* Add forward_trajectory local solver plugin (moveit#359) * Use ros2_control based joint simulation and remove unnecessary comment * Update copyrights * Restructure hybrid planning package * Fix formatting and add missing time stamp in local solver plugin * Remove unnecessary logging and param loading * Enable different interfaces between local planner and controller * Use JointGroupPositionController as demo hardware controller
sjahr
added a commit
to sjahr/moveit2
that referenced
this pull request
Nov 18, 2021
* Add forward_trajectory local solver plugin (moveit#359) * Use ros2_control based joint simulation and remove unnecessary comment * Update copyrights * Restructure hybrid planning package * Fix formatting and add missing time stamp in local solver plugin * Remove unnecessary logging and param loading * Enable different interfaces between local planner and controller * Use JointGroupPositionController as demo hardware controller
AndyZe
pushed a commit
to AndyZe/moveit2
that referenced
this pull request
Nov 24, 2021
* Add forward_trajectory local solver plugin (moveit#359) * Use ros2_control based joint simulation and remove unnecessary comment * Update copyrights * Restructure hybrid planning package * Fix formatting and add missing time stamp in local solver plugin * Remove unnecessary logging and param loading * Enable different interfaces between local planner and controller * Use JointGroupPositionController as demo hardware controller
AndyZe
pushed a commit
to AndyZe/moveit2
that referenced
this pull request
Nov 29, 2021
* Add forward_trajectory local solver plugin (moveit#359) * Use ros2_control based joint simulation and remove unnecessary comment * Update copyrights * Restructure hybrid planning package * Fix formatting and add missing time stamp in local solver plugin * Remove unnecessary logging and param loading * Enable different interfaces between local planner and controller * Use JointGroupPositionController as demo hardware controller
AndyZe
pushed a commit
to AndyZe/moveit2
that referenced
this pull request
Nov 30, 2021
* Add forward_trajectory local solver plugin (moveit#359) * Use ros2_control based joint simulation and remove unnecessary comment * Update copyrights * Restructure hybrid planning package * Fix formatting and add missing time stamp in local solver plugin * Remove unnecessary logging and param loading * Enable different interfaces between local planner and controller * Use JointGroupPositionController as demo hardware controller
AndyZe
pushed a commit
to AndyZe/moveit2
that referenced
this pull request
Dec 3, 2021
* Add forward_trajectory local solver plugin (moveit#359) * Use ros2_control based joint simulation and remove unnecessary comment * Update copyrights * Restructure hybrid planning package * Fix formatting and add missing time stamp in local solver plugin * Remove unnecessary logging and param loading * Enable different interfaces between local planner and controller * Use JointGroupPositionController as demo hardware controller
AndyZe
pushed a commit
to AndyZe/moveit2
that referenced
this pull request
Dec 7, 2021
* Add forward_trajectory local solver plugin (moveit#359) * Use ros2_control based joint simulation and remove unnecessary comment * Update copyrights * Restructure hybrid planning package * Fix formatting and add missing time stamp in local solver plugin * Remove unnecessary logging and param loading * Enable different interfaces between local planner and controller * Use JointGroupPositionController as demo hardware controller
AndyZe
pushed a commit
to AndyZe/moveit2
that referenced
this pull request
Dec 7, 2021
* Add forward_trajectory local solver plugin (moveit#359) * Use ros2_control based joint simulation and remove unnecessary comment * Update copyrights * Restructure hybrid planning package * Fix formatting and add missing time stamp in local solver plugin * Remove unnecessary logging and param loading * Enable different interfaces between local planner and controller * Use JointGroupPositionController as demo hardware controller
MikeWrock
pushed a commit
to MikeWrock/moveit2
that referenced
this pull request
Aug 15, 2022
Signed-off-by: Tyler Weaver <tylerjw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a local solver plugin to the hybrid planning architecture, that simply forwards the local solution trajectory-point-wise to the underlying controller.
Checklist