-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EXPORT install in CMake #372
Conversation
Signed-off-by: Tyler Weaver <tylerjw@gmail.com>
ea2a56d
to
c989702
Compare
I force-pushed to this after fixing a couple of issues I discovered that this caused (ament_lint_cmake and an issue with the install of binaries in moveit_servo). Those issues should be resolved and travis should pass. |
Codecov Report
@@ Coverage Diff @@
## main #372 +/- ##
==========================================
+ Coverage 53.22% 53.25% +0.04%
==========================================
Files 209 209
Lines 18849 18849
==========================================
+ Hits 10030 10036 +6
+ Misses 8819 8813 -6
Continue to review full report at Codecov.
|
I created this gist to explain the Boost stuff: https://gist.github.com/tylerjw/ce3bcb94b3df7996e450dec18ee54cde I plan on doing a tiny lightning talk for WMD on this. It was confusing for me to figure out, hopefully, it'll help others. |
find_package(eigen3_cmake_module REQUIRED) | ||
find_package(Eigen3 REQUIRED) | ||
|
||
# Finds Boost Components | ||
include(ConfigExtras.cmake) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really neat solution!
moveit_trajectory_rviz_plugin_core | ||
) | ||
|
||
set(THIS_PACKAGE_INCLUDE_DEPENDS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be missing moveit_ros_warehouse
. It wasn't exported before, but for some reason MTC failed to compile when not using a symlink ws.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@henningkayser @JafarAbdi I believe this PR is now ready to be merged. |
When this is merged, please just do the squash and merge. |
Description
This should fix all EXPORTs in the install commands in cmake. This makes so --symlink-install works correctly and so you can run
colcon test
aftercolcon build
without sourcing the local workspace.One thing nice about this is it net reduces the cmake code and I think is simpler to read and replicate than what we had before that didn't work.
References
Reason for the ConfigExtras.cmake files with the Boost find_package commands: https://answers.ros.org/question/331089/ament_export_dependenciesboost-not-working/?answer=332460#post-id-332460
Code reference for the CONFIG_EXTRAS parameter to ament_package: https://github.com/ament/ament_cmake/blob/95cab1de1cd6bd7caad34d0122e11b2e86310ee2/ament_cmake_core/cmake/core/ament_package.cmake#L24-L32
The issue I created against ament_cmake documenting how I think the documentation should read about cmake install of libraries: ament/ament_cmake#317
The official documentation: https://index.ros.org/doc/ros2/Tutorials/Ament-CMake-Documentation/#building-a-library
Checklist