Replace last ament_export_libraries macro calls #448
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the last remaining ament_export_libraries() macro calls with ament_export_targets()
Description
I've experienced trouble with missing include directories when trying to use the moveit_servo library in another package.
To reproduce, try to add
to a header file in a package outside of the moveit_servo package (with moveit_servo properly set up as CMake dependency).
When trying to build the package I got the error:
The problem seemed to be caused by the usage of the "ament_export_libraries" macro which seems to be outdated and replaced (#372 ) in most of moveit2's packages anyway. Replacing the macro fixed the issue for me.
Checklist