Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace last ament_export_libraries macro calls #448

Merged
merged 1 commit into from
May 3, 2021

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented May 2, 2021

This PR replaces the last remaining ament_export_libraries() macro calls with ament_export_targets()

Description

I've experienced trouble with missing include directories when trying to use the moveit_servo library in another package.
To reproduce, try to add

#include <moveit_servo/servo.h>

to a header file in a package outside of the moveit_servo package (with moveit_servo properly set up as CMake dependency).
When trying to build the package I got the error:

fatal error: moveit_servo/servo.h: No such file or directory

The problem seemed to be caused by the usage of the "ament_export_libraries" macro which seems to be outdated and replaced (#372 ) in most of moveit2's packages anyway. Replacing the macro fixed the issue for me.

Checklist

@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #448 (14f087b) into main (3a41a20) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
- Coverage   52.01%   51.98%   -0.02%     
==========================================
  Files         223      223              
  Lines       23340    23340              
==========================================
- Hits        12137    12131       -6     
- Misses      11203    11209       +6     
Impacted Files Coverage Δ
.../ompl_interface/src/detail/constrained_sampler.cpp 43.25% <0.00%> (-16.21%) ⬇️
...meterization/work_space/pose_model_state_space.cpp 81.14% <0.00%> (-1.88%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 56.24% <0.00%> (+0.13%) ⬆️
...e/collision_detection_fcl/src/collision_common.cpp 75.19% <0.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce190f...14f087b. Read the comment docs.

@henningkayser henningkayser merged commit b5ad6b0 into moveit:main May 3, 2021
@sjahr sjahr deleted the pr-replace_ament_macro branch May 20, 2021 09:07
@sjahr sjahr restored the pr-replace_ament_macro branch May 20, 2021 09:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants