Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hybrid planning includes #675

Conversation

henningkayser
Copy link
Member

@henningkayser henningkayser commented Sep 10, 2021

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #675 (239a8cb) into feature/hybrid_planning (ee7ad8f) will increase coverage by 8.11%.
The diff coverage is 56.97%.

Impacted file tree graph

@@                     Coverage Diff                     @@
##           feature/hybrid_planning     #675      +/-   ##
===========================================================
+ Coverage                    46.01%   54.11%   +8.11%     
===========================================================
  Files                          170      190      +20     
  Lines                        18731    20037    +1306     
===========================================================
+ Hits                          8617    10842    +2225     
+ Misses                       10114     9195     -919     
Impacted Files Coverage Δ
...lude/moveit/collision_detection/collision_common.h 76.75% <ø> (ø)
...collision_detection/collision_detector_allocator.h 84.62% <ø> (ø)
...include/moveit/collision_detection/collision_env.h 100.00% <ø> (ø)
...lude/moveit/collision_detection/collision_matrix.h 100.00% <ø> (ø)
.../collision_detection/test_collision_common_panda.h 94.71% <ø> (ø)
...tection/include/moveit/collision_detection/world.h 100.00% <ø> (ø)
...on/include/moveit/collision_detection/world_diff.h 60.00% <ø> (ø)
...t_core/collision_detection/src/collision_tools.cpp 0.00% <ø> (ø)
...ion_bullet/bullet_integration/bullet_bvh_manager.h 0.00% <ø> (ø)
...ullet/bullet_integration/bullet_cast_bvh_manager.h 100.00% <ø> (ø)
... and 108 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42414ae...239a8cb. Read the comment docs.

Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, thanks for fixing this!

@henningkayser henningkayser merged commit 341db91 into moveit:feature/hybrid_planning Sep 13, 2021
sjahr pushed a commit to sjahr/moveit2 that referenced this pull request Sep 28, 2021
sjahr pushed a commit to sjahr/moveit2 that referenced this pull request Oct 19, 2021
sjahr pushed a commit to sjahr/moveit2 that referenced this pull request Oct 28, 2021
sjahr pushed a commit to sjahr/moveit2 that referenced this pull request Nov 18, 2021
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Nov 24, 2021
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Nov 29, 2021
…eit#585)

Fix hybrid planning include folders (moveit#675)

Order stuff in the CMakeLists.txt and remove control_box package

Update README

Move member initialization to initializer lists

Remove control_box include dependency

Replace "loop-run" with "iteration"

Remove cpp interface class constructors and destructors

Use joint_state_broadcaster, clean up test node, add execution dependencies

Use only plugin interface header files and add missing dependencies

Clean up constructor and destructor definitions

Declare missing parameter in moveit_planning_pipeline_plugin

Move rclcpp::Loggers into anonymous namespaces

Switch CI branches to feature/hybrid_planning

Update message name

Remove moveit_msgs from .repos file

Update github workflows

Remove note from readme about building from source

Minor renamings, make reset() noexcept

Check for vector length of zero

Load moveit_cpp options with the Options helper. Reduces LOC.

Set the planning parameters within plan()

Function renaming

Authors and descriptions in header files only. New header file for error code interface.

Update namespacing

Use default QoS for subscribers

Better progress comparison

Add publish_joint_positions and publish_joint_velocities param

Grammar and other minor nitpicks

Restore moveit_msgs to .repos, for now
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Nov 29, 2021
…eit#585)

Fix hybrid planning include folders (moveit#675)

Order stuff in the CMakeLists.txt and remove control_box package

Update README

Move member initialization to initializer lists

Remove control_box include dependency

Replace "loop-run" with "iteration"

Remove cpp interface class constructors and destructors

Use joint_state_broadcaster, clean up test node, add execution dependencies

Use only plugin interface header files and add missing dependencies

Clean up constructor and destructor definitions

Declare missing parameter in moveit_planning_pipeline_plugin

Move rclcpp::Loggers into anonymous namespaces

Switch CI branches to feature/hybrid_planning

Update message name

Remove moveit_msgs from .repos file

Update github workflows

Remove note from readme about building from source

Minor renamings, make reset() noexcept

Check for vector length of zero

Load moveit_cpp options with the Options helper. Reduces LOC.

Set the planning parameters within plan()

Function renaming

Authors and descriptions in header files only. New header file for error code interface.

Update namespacing

Use default QoS for subscribers

Better progress comparison

Add publish_joint_positions and publish_joint_velocities param

Grammar and other minor nitpicks

Restore moveit_msgs to .repos, for now
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Nov 30, 2021
…eit#585)

Fix hybrid planning include folders (moveit#675)

Order stuff in the CMakeLists.txt and remove control_box package

Update README

Move member initialization to initializer lists

Remove control_box include dependency

Replace "loop-run" with "iteration"

Remove cpp interface class constructors and destructors

Use joint_state_broadcaster, clean up test node, add execution dependencies

Use only plugin interface header files and add missing dependencies

Clean up constructor and destructor definitions

Declare missing parameter in moveit_planning_pipeline_plugin

Move rclcpp::Loggers into anonymous namespaces

Switch CI branches to feature/hybrid_planning

Update message name

Remove moveit_msgs from .repos file

Update github workflows

Remove note from readme about building from source

Minor renamings, make reset() noexcept

Check for vector length of zero

Load moveit_cpp options with the Options helper. Reduces LOC.

Set the planning parameters within plan()

Function renaming

Authors and descriptions in header files only. New header file for error code interface.

Update namespacing

Use default QoS for subscribers

Better progress comparison

Add publish_joint_positions and publish_joint_velocities param

Grammar and other minor nitpicks

Restore moveit_msgs to .repos, for now
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Dec 3, 2021
…eit#585)

Fix hybrid planning include folders (moveit#675)

Order stuff in the CMakeLists.txt and remove control_box package

Update README

Move member initialization to initializer lists

Remove control_box include dependency

Replace "loop-run" with "iteration"

Remove cpp interface class constructors and destructors

Use joint_state_broadcaster, clean up test node, add execution dependencies

Use only plugin interface header files and add missing dependencies

Clean up constructor and destructor definitions

Declare missing parameter in moveit_planning_pipeline_plugin

Move rclcpp::Loggers into anonymous namespaces

Switch CI branches to feature/hybrid_planning

Update message name

Remove moveit_msgs from .repos file

Update github workflows

Remove note from readme about building from source

Minor renamings, make reset() noexcept

Check for vector length of zero

Load moveit_cpp options with the Options helper. Reduces LOC.

Set the planning parameters within plan()

Function renaming

Authors and descriptions in header files only. New header file for error code interface.

Update namespacing

Use default QoS for subscribers

Better progress comparison

Add publish_joint_positions and publish_joint_velocities param

Grammar and other minor nitpicks

Restore moveit_msgs to .repos, for now
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Dec 7, 2021
…eit#585)

Fix hybrid planning include folders (moveit#675)

Order stuff in the CMakeLists.txt and remove control_box package

Update README

Move member initialization to initializer lists

Remove control_box include dependency

Replace "loop-run" with "iteration"

Remove cpp interface class constructors and destructors

Use joint_state_broadcaster, clean up test node, add execution dependencies

Use only plugin interface header files and add missing dependencies

Clean up constructor and destructor definitions

Declare missing parameter in moveit_planning_pipeline_plugin

Move rclcpp::Loggers into anonymous namespaces

Switch CI branches to feature/hybrid_planning

Update message name

Remove moveit_msgs from .repos file

Update github workflows

Remove note from readme about building from source

Minor renamings, make reset() noexcept

Check for vector length of zero

Load moveit_cpp options with the Options helper. Reduces LOC.

Set the planning parameters within plan()

Function renaming

Authors and descriptions in header files only. New header file for error code interface.

Update namespacing

Use default QoS for subscribers

Better progress comparison

Add publish_joint_positions and publish_joint_velocities param

Grammar and other minor nitpicks

Restore moveit_msgs to .repos, for now
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Dec 7, 2021
…eit#585)

Fix hybrid planning include folders (moveit#675)

Order stuff in the CMakeLists.txt and remove control_box package

Update README

Move member initialization to initializer lists

Remove control_box include dependency

Replace "loop-run" with "iteration"

Remove cpp interface class constructors and destructors

Use joint_state_broadcaster, clean up test node, add execution dependencies

Use only plugin interface header files and add missing dependencies

Clean up constructor and destructor definitions

Declare missing parameter in moveit_planning_pipeline_plugin

Move rclcpp::Loggers into anonymous namespaces

Switch CI branches to feature/hybrid_planning

Update message name

Remove moveit_msgs from .repos file

Update github workflows

Remove note from readme about building from source

Minor renamings, make reset() noexcept

Check for vector length of zero

Load moveit_cpp options with the Options helper. Reduces LOC.

Set the planning parameters within plan()

Function renaming

Authors and descriptions in header files only. New header file for error code interface.

Update namespacing

Use default QoS for subscribers

Better progress comparison

Add publish_joint_positions and publish_joint_velocities param

Grammar and other minor nitpicks

Restore moveit_msgs to .repos, for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants