Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global planner plugin interface #585

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented Aug 1, 2021

Description

Instead of the MoveIt planning pipeline, the global planner component is extended with a global planner plugin to support various global planner implementations like the planning pipeline or MTC. To try it, please use this branch of my moveit_msgs fork.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference

@henningkayser
Copy link
Member

@sjahr could you rebase this PR?

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #585 (8b98fc6) into feature/hybrid_planning (41eed5b) will not change coverage.
The diff coverage is n/a.

❗ Current head 8b98fc6 differs from pull request most recent head 209adbe. Consider uploading reports for the commit 209adbe to get more accurate results
Impacted file tree graph

@@                   Coverage Diff                    @@
##           feature/hybrid_planning     #585   +/-   ##
========================================================
  Coverage                    54.11%   54.11%           
========================================================
  Files                          190      190           
  Lines                        20037    20037           
========================================================
  Hits                         10842    10842           
  Misses                        9195     9195           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41eed5b...209adbe. Read the comment docs.

@sjahr sjahr force-pushed the pr-add_global_planner_plugin branch 3 times, most recently from e5bc238 to 5a11025 Compare September 9, 2021 14:05
@sjahr sjahr force-pushed the pr-add_global_planner_plugin branch from 5a11025 to 209adbe Compare September 9, 2021 15:35
@henningkayser
Copy link
Member

galactic fails because of ros2_control

@henningkayser henningkayser merged commit 42414ae into moveit:feature/hybrid_planning Sep 9, 2021
sjahr added a commit to sjahr/moveit2 that referenced this pull request Sep 28, 2021
sjahr added a commit to sjahr/moveit2 that referenced this pull request Oct 19, 2021
sjahr added a commit to sjahr/moveit2 that referenced this pull request Oct 28, 2021
sjahr added a commit to sjahr/moveit2 that referenced this pull request Nov 18, 2021
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Nov 24, 2021
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Nov 29, 2021
…eit#585)

Fix hybrid planning include folders (moveit#675)

Order stuff in the CMakeLists.txt and remove control_box package

Update README

Move member initialization to initializer lists

Remove control_box include dependency

Replace "loop-run" with "iteration"

Remove cpp interface class constructors and destructors

Use joint_state_broadcaster, clean up test node, add execution dependencies

Use only plugin interface header files and add missing dependencies

Clean up constructor and destructor definitions

Declare missing parameter in moveit_planning_pipeline_plugin

Move rclcpp::Loggers into anonymous namespaces

Switch CI branches to feature/hybrid_planning

Update message name

Remove moveit_msgs from .repos file

Update github workflows

Remove note from readme about building from source

Minor renamings, make reset() noexcept

Check for vector length of zero

Load moveit_cpp options with the Options helper. Reduces LOC.

Set the planning parameters within plan()

Function renaming

Authors and descriptions in header files only. New header file for error code interface.

Update namespacing

Use default QoS for subscribers

Better progress comparison

Add publish_joint_positions and publish_joint_velocities param

Grammar and other minor nitpicks

Restore moveit_msgs to .repos, for now
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Nov 29, 2021
…eit#585)

Fix hybrid planning include folders (moveit#675)

Order stuff in the CMakeLists.txt and remove control_box package

Update README

Move member initialization to initializer lists

Remove control_box include dependency

Replace "loop-run" with "iteration"

Remove cpp interface class constructors and destructors

Use joint_state_broadcaster, clean up test node, add execution dependencies

Use only plugin interface header files and add missing dependencies

Clean up constructor and destructor definitions

Declare missing parameter in moveit_planning_pipeline_plugin

Move rclcpp::Loggers into anonymous namespaces

Switch CI branches to feature/hybrid_planning

Update message name

Remove moveit_msgs from .repos file

Update github workflows

Remove note from readme about building from source

Minor renamings, make reset() noexcept

Check for vector length of zero

Load moveit_cpp options with the Options helper. Reduces LOC.

Set the planning parameters within plan()

Function renaming

Authors and descriptions in header files only. New header file for error code interface.

Update namespacing

Use default QoS for subscribers

Better progress comparison

Add publish_joint_positions and publish_joint_velocities param

Grammar and other minor nitpicks

Restore moveit_msgs to .repos, for now
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Nov 30, 2021
…eit#585)

Fix hybrid planning include folders (moveit#675)

Order stuff in the CMakeLists.txt and remove control_box package

Update README

Move member initialization to initializer lists

Remove control_box include dependency

Replace "loop-run" with "iteration"

Remove cpp interface class constructors and destructors

Use joint_state_broadcaster, clean up test node, add execution dependencies

Use only plugin interface header files and add missing dependencies

Clean up constructor and destructor definitions

Declare missing parameter in moveit_planning_pipeline_plugin

Move rclcpp::Loggers into anonymous namespaces

Switch CI branches to feature/hybrid_planning

Update message name

Remove moveit_msgs from .repos file

Update github workflows

Remove note from readme about building from source

Minor renamings, make reset() noexcept

Check for vector length of zero

Load moveit_cpp options with the Options helper. Reduces LOC.

Set the planning parameters within plan()

Function renaming

Authors and descriptions in header files only. New header file for error code interface.

Update namespacing

Use default QoS for subscribers

Better progress comparison

Add publish_joint_positions and publish_joint_velocities param

Grammar and other minor nitpicks

Restore moveit_msgs to .repos, for now
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Dec 3, 2021
…eit#585)

Fix hybrid planning include folders (moveit#675)

Order stuff in the CMakeLists.txt and remove control_box package

Update README

Move member initialization to initializer lists

Remove control_box include dependency

Replace "loop-run" with "iteration"

Remove cpp interface class constructors and destructors

Use joint_state_broadcaster, clean up test node, add execution dependencies

Use only plugin interface header files and add missing dependencies

Clean up constructor and destructor definitions

Declare missing parameter in moveit_planning_pipeline_plugin

Move rclcpp::Loggers into anonymous namespaces

Switch CI branches to feature/hybrid_planning

Update message name

Remove moveit_msgs from .repos file

Update github workflows

Remove note from readme about building from source

Minor renamings, make reset() noexcept

Check for vector length of zero

Load moveit_cpp options with the Options helper. Reduces LOC.

Set the planning parameters within plan()

Function renaming

Authors and descriptions in header files only. New header file for error code interface.

Update namespacing

Use default QoS for subscribers

Better progress comparison

Add publish_joint_positions and publish_joint_velocities param

Grammar and other minor nitpicks

Restore moveit_msgs to .repos, for now
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Dec 7, 2021
…eit#585)

Fix hybrid planning include folders (moveit#675)

Order stuff in the CMakeLists.txt and remove control_box package

Update README

Move member initialization to initializer lists

Remove control_box include dependency

Replace "loop-run" with "iteration"

Remove cpp interface class constructors and destructors

Use joint_state_broadcaster, clean up test node, add execution dependencies

Use only plugin interface header files and add missing dependencies

Clean up constructor and destructor definitions

Declare missing parameter in moveit_planning_pipeline_plugin

Move rclcpp::Loggers into anonymous namespaces

Switch CI branches to feature/hybrid_planning

Update message name

Remove moveit_msgs from .repos file

Update github workflows

Remove note from readme about building from source

Minor renamings, make reset() noexcept

Check for vector length of zero

Load moveit_cpp options with the Options helper. Reduces LOC.

Set the planning parameters within plan()

Function renaming

Authors and descriptions in header files only. New header file for error code interface.

Update namespacing

Use default QoS for subscribers

Better progress comparison

Add publish_joint_positions and publish_joint_velocities param

Grammar and other minor nitpicks

Restore moveit_msgs to .repos, for now
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Dec 7, 2021
…eit#585)

Fix hybrid planning include folders (moveit#675)

Order stuff in the CMakeLists.txt and remove control_box package

Update README

Move member initialization to initializer lists

Remove control_box include dependency

Replace "loop-run" with "iteration"

Remove cpp interface class constructors and destructors

Use joint_state_broadcaster, clean up test node, add execution dependencies

Use only plugin interface header files and add missing dependencies

Clean up constructor and destructor definitions

Declare missing parameter in moveit_planning_pipeline_plugin

Move rclcpp::Loggers into anonymous namespaces

Switch CI branches to feature/hybrid_planning

Update message name

Remove moveit_msgs from .repos file

Update github workflows

Remove note from readme about building from source

Minor renamings, make reset() noexcept

Check for vector length of zero

Load moveit_cpp options with the Options helper. Reduces LOC.

Set the planning parameters within plan()

Function renaming

Authors and descriptions in header files only. New header file for error code interface.

Update namespacing

Use default QoS for subscribers

Better progress comparison

Add publish_joint_positions and publish_joint_velocities param

Grammar and other minor nitpicks

Restore moveit_msgs to .repos, for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants