Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source versions of ros2_control, ros2_controllers #689

Merged

Conversation

henningkayser
Copy link
Member

@henningkayser henningkayser commented Sep 20, 2021

Fixes CI by only installing released versions for Galactic. This should also prevent sync issues in the future.

@tylerjw
Copy link
Member

tylerjw commented Sep 20, 2021

Failing for the galactic ruckig issue.

@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #689 (75a3d41) into main (e75e6cc) will not change coverage.
The diff coverage is 18.19%.

❗ Current head 75a3d41 differs from pull request most recent head c6d8d3a. Consider uploading reports for the commit c6d8d3a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #689   +/-   ##
=======================================
  Coverage   54.16%   54.16%           
=======================================
  Files         192      192           
  Lines       20180    20180           
=======================================
  Hits        10929    10929           
  Misses       9251     9251           
Impacted Files Coverage Δ
...include/moveit/collision_detection/occupancy_map.h 0.00% <ø> (ø)
moveit_core/profiler/src/profiler.cpp 64.07% <0.00%> (ø)
...rajectory_processing/src/ruckig_traj_smoothing.cpp 0.00% <0.00%> (ø)
...veit/occupancy_map_monitor/occupancy_map_monitor.h 25.00% <0.00%> (ø)
...veit/occupancy_map_monitor/occupancy_map_updater.h 0.00% <ø> (ø)
moveit_core/planning_scene/src/planning_scene.cpp 42.10% <7.70%> (ø)
...nning_scene_monitor/src/planning_scene_monitor.cpp 45.49% <66.67%> (ø)
...ccupancy_map_monitor/src/occupancy_map_monitor.cpp 18.90% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e75e6cc...c6d8d3a. Read the comment docs.

@henningkayser henningkayser force-pushed the pr-fix_ros2_control_versions branch 2 times, most recently from 6582c97 to ab55bb9 Compare September 21, 2021 10:58
@henningkayser henningkayser merged commit fc3909e into moveit:main Sep 21, 2021
@henningkayser
Copy link
Member Author

I just merged the first commit, the second warning fix went into #690

@henningkayser henningkayser deleted the pr-fix_ros2_control_versions branch September 21, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants