Fix cmake warnings

[henningkayser]

This fixes the build warnings discovered here https://github.com/ros-planning/moveit2/runs/3662305871?check_suite_focus=true#step:8:689. Should we enforce the build to be free of warnings?

[codecov]

Codecov Report

Merging #690 (40ff79b) into main (584618d) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
- Coverage   54.16%   54.14%   -0.02%     
==========================================
  Files         192      192              
  Lines       20180    20180              
==========================================
- Hits        10929    10924       -5     
- Misses       9251     9256       +5     

Impacted Files	Coverage Δ
.../collision_detection_fcl/src/collision_env_fcl.cpp	89.80% <ø> (ø)
moveit_core/profiler/src/profiler.cpp	64.07% <0.00%> (ø)
...oveit_servo/include/moveit_servo/collision_check.h	100.00% <ø> (ø)
moveit_ros/moveit_servo/src/collision_check.cpp	85.72% <ø> (ø)
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp	72.84% <0.00%> (-1.88%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8cfe4d...40ff79b. Read the comment docs.

[destogl]

This looks good. I suggest renaming the PR to something like "Fix build warnings". I found "cmake" in the title somewhat misleading.

There is also one more clang-tidy issue.

[DLu]

Possible fix for clang-tidy: henningkayser#11

[JafarAbdi]

Should we enforce the build to be free of warnings?

+1, the only problem with this is it may force us to branch off galactic since some features are deprecated in rolling and the alternatives don't exist in galactic

[v4hn]

Should we enforce the build to be free of warnings

We do that for moveit, so I think it's a very good idea to enforce it for moveit2 as well!

+1, the only problem with this is it may force us to branch off galactic since some features are deprecated in rolling and the alternatives don't exist in galactic

I would argue that using deprecated API should still be avoided in the newer distro, possibly using #ifdef approaches to support both alternatives.
That way, you can add clear TODOs to address when galactic support is dropped in the branch.