Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable use_intra_process_comms in servo launch files #722

Merged
merged 3 commits into from
Oct 11, 2021

Conversation

tylerjw
Copy link
Member

@tylerjw tylerjw commented Oct 4, 2021

Description

This is a fix for Rolling as enabling this causes the component container to die with this error:

[ERROR] [test_servo_integration_container]: Component constructor threw an exception: intraprocess communication is not allowed with a zero qos history depth value

Note there was also a typo in servo_launch_test_common.py (missing a s).

On the changes in servo_example.launch.py. Even if we could enable it for the two components it is enabled for it is a major pessimization to enable it for only some of the nodes within a container.

Checklist

@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #722 (e7e8f92) into main (26a2ab7) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
- Coverage   54.23%   54.21%   -0.01%     
==========================================
  Files         192      192              
  Lines       20224    20224              
==========================================
- Hits        10966    10963       -3     
- Misses       9258     9261       +3     
Impacted Files Coverage Δ
...nning_scene_monitor/src/planning_scene_monitor.cpp 45.31% <0.00%> (-0.50%) ⬇️
...e/collision_detection_fcl/src/collision_common.cpp 74.64% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26a2ab7...e7e8f92. Read the comment docs.

Copy link
Contributor

@vatanaksoytezer vatanaksoytezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tylerjw tylerjw added this to In progress in Rolling, Galactic - 2.3.1 - November 26 2021 via automation Oct 5, 2021
Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably remove this warning, also. Do we even have a history depth of 0? Should we enforce something else in the profile and suggest enabling intra process comms on all components?

@tylerjw
Copy link
Member Author

tylerjw commented Oct 5, 2021

Somewhere in moveit (I'm assuming) we do have a history depth of 0 for some topic and that is the cause of this.

Rolling, Galactic - 2.3.1 - November 26 2021 automation moved this from In progress to Reviewer approved Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants