-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable use_intra_process_comms in servo launch files #722
Disable use_intra_process_comms in servo launch files #722
Conversation
3acb2f0
to
f6a0436
Compare
Codecov Report
@@ Coverage Diff @@
## main #722 +/- ##
==========================================
- Coverage 54.23% 54.21% -0.01%
==========================================
Files 192 192
Lines 20224 20224
==========================================
- Hits 10966 10963 -3
- Misses 9258 9261 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also change the ones in tests as well: https://github.com/ros-planning/moveit2/blob/main/moveit_ros/moveit_servo/test/launch/servo_launch_test_common.py#L150 Sorry my bad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably remove this warning, also. Do we even have a history depth of 0? Should we enforce something else in the profile and suggest enabling intra process comms on all components?
Somewhere in moveit (I'm assuming) we do have a history depth of 0 for some topic and that is the cause of this. |
Description
This is a fix for Rolling as enabling this causes the component container to die with this error:
Note there was also a typo in
servo_launch_test_common.py
(missing a s).On the changes in
servo_example.launch.py
. Even if we could enable it for the two components it is enabled for it is a major pessimization to enable it for only some of the nodes within a container.Checklist