Fix response future type

[tylerjw]

Description

I've tested this fixing this error on galactic. It needs to be also tested on rolling:

--- stderr: moveit2_tutorials                                                                                             
/home/tyler/code/m2/ws_tutorial/src/moveit2_tutorials/doc/planning_scene_ros_api/src/planning_scene_ros_api_tutorial.cpp: In function ‘int main(int, char**)’:
/home/tyler/code/m2/ws_tutorial/src/moveit2_tutorials/doc/planning_scene_ros_api/src/planning_scene_ros_api_tutorial.cpp:164:77: error: ‘using SharedFuture = class std::shared_future<std::shared_ptr<moveit_msgs::srv::ApplyPlanningScene_Response_<std::allocator<void> > > >’ {aka ‘class std::shared_future<std::shared_ptr<moveit_msgs::srv::ApplyPlanningScene_Response_<std::allocator<void> > > >’} has no member named ‘future’
  164 |   response_future = planning_scene_diff_client->async_send_request(request).future.share();
      |                                                                             ^~~~~~
make[2]: *** [doc/planning_scene_ros_api/CMakeFiles/planning_scene_ros_api_tutorial.dir/build.make:63: doc/planning_scene_ros_api/CMakeFiles/planning_scene_ros_api_tutorial.dir/src/planning_scene_ros_api_tutorial.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:332: doc/planning_scene_ros_api/CMakeFiles/planning_scene_ros_api_tutorial.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:141: all] Error 2
---
Failed   <<< moveit2_tutorials [21.1s, exited with code 2]

Checklist

• Required by CI: Code is auto formatted using clang-format
• While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

[vatanaksoytezer]

Any idea why CI didn't catch this @tylerjw ?

[tylerjw]

No idea. I didn't look into why CI didn't catch this but I did reproduce it locally.

[vatanaksoytezer]

This also happened in the scheduled build of foxy 2 days ago: https://github.com/ros-planning/moveit2_tutorials/runs/4126809816?check_suite_focus=true. So needs to be backported to foxy.

[vatanaksoytezer]

Seems foxy and galactic is broken, rolling is fine with this included or not. I say we merge this in all distros.

[tylerjw]

I tested this on rolling too.