[ros2] WINDOWS_EXPORT_ALL_SYMBOLS property for portability #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g RANDOM_NUMBERS_PUBLIC to the class header.
Add symbol visibility for Windows
lilustga
changed the title
|
In the past, I have seen the opposite approach taken in the ROS community, i.e. introducing explicit symbol visibility, e.g. |
Yes, it makes more sense for our code base than specifying visibility for each and every single definition. |
tylerjw
approved these changes
Sep 16, 2020
henningkayser
approved these changes
Nov 24, 2020
traversaro
added a commit
to traversaro/random_numbers
that referenced
this pull request
Jan 15, 2021
Backport of moveit#23 to master (ROS1) branch.
v4hn
pushed a commit
that referenced
this pull request
Aug 6, 2021
Backport of #23 to master (ROS1) branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the WINDOWS_EXPORT_ALL_SYMBOLS property which causes symbols do be made visible by default when building with MSVC (to match the behavior of gcc).