Skip to content

Configure linting (and lint!) #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 12, 2025
Merged

Configure linting (and lint!) #28

merged 2 commits into from
Aug 12, 2025

Conversation

peteski22
Copy link
Contributor

Summary

Follow up to #25.

  • Add ruff.toml, remove settings from pyproject.toml
  • Linting fixes
  • Bug: Fix JSON Schema Null Type Handling

Linting Configuration

  • Migrated from pyproject.toml to dedicated ruff.toml configuration file
  • Expanded linting rules to include naming conventions (N), string concatenation (ISC), pathlib usage (PTH), and docstrings (D)
  • Configured stricter rules appropriate for a public SDK with no ignored docstring requirements
  • Set up Google docstring convention and appropriate per-file ignores

Refs: #25

@peteski22
Configure linting (and lint!)
97e99fe 
* Add ruff.toml, remove settings from pyproject.toml
* Linting fixes
* Bug: Fix JSON Schema Null Type Handling
@peteski22 peteski22 requested a review from aittalam August 12, 2025 11:46
aittalam
aittalam approved these changes Aug 12, 2025
View reviewed changes
Copy link
Member

@aittalam aittalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit comment but apart from that looks good. Pre-approved, thanks!

@peteski22 peteski22 merged commit f5fdd48 into main Aug 12, 2025
7 checks passed
@peteski22 peteski22 deleted the peteski22/linting branch August 12, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aittalam aittalam aittalam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peteski22 @aittalam