Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Try to get rid of appcompat dependency #13

Closed
mcomella opened this issue Jun 17, 2017 · 3 comments
Closed

Try to get rid of appcompat dependency #13

mcomella opened this issue Jun 17, 2017 · 3 comments
Labels
ARCHIVED CLOSED at time of archiving

Comments

@mcomella
Copy link
Contributor

It was in there by default and now the style for our LoginActivity relies on it. It'd be great to not force the implementing application to have more methods than they really need.

At the very least, we should make the version required more lenient so the application won't have to download two versions of the support library.

With this change, we may also need to drop the use of our support library annotations.

@Sdaswani
Copy link

Will removing appcompat change our public API?

@mcomella
Copy link
Contributor Author

mcomella commented Jun 19, 2017 via email

@mcomella
Copy link
Contributor Author

FYI: the support libraries make the biggest impact on our method count at 19898 methods (compared to 1681 methods in the org.mozilla code). See the dexcount output.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ARCHIVED CLOSED at time of archiving
Projects
None yet
Development

No branches or pull requests

3 participants