Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear notification and download jobs when onTaskRemoved or onDestroy are called #6764

Closed
Amejia481 opened this issue Apr 24, 2020 · 0 comments
Closed

Clear notification and download jobs when onTaskRemoved or onDestroy are called #6764

Amejia481 opened this issue Apr 24, 2020 · 0 comments
Assignees
@Amejia481
Labels
<download>

Comments

@Amejia481
Copy link
Contributor

@Amejia481 Amejia481 commented Apr 24, 2020 •
edited by data-sync-user

We were partially cleaning notifications/jobs when onTaskRemoved and onDestroy assuming that they were called one after another, but in reality, after doing some testing is they can be called independently.

When onTaskRemoved was called onDestroy wasn't called after, for this reason we have to make sure we clean our resources in both methods to avoid issues like mozilla-mobile/fenix#9884

┆Issue is synchronized with this Jira Task
@Amejia481 Amejia481 self-assigned this Apr 24, 2020
@Amejia481 Amejia481 added the <download> label Apr 24, 2020
@Amejia481 Amejia481 changed the title Clear notification and downlod jobs when onTaskRemoved or onDestroy are called Clear notification and download jobs when onTaskRemoved or onDestroy are called Apr 24, 2020
Amejia481 added a commit to Amejia481/android-components that referenced this issue Apr 24, 2020
@Amejia481
Closes mozilla-mobile#6764 Clear notification and download jobs when
071115d 
onTaskRemoved or onDestroy are called.
bors bot pushed a commit that referenced this issue Apr 24, 2020
@MozLando @Amejia481
Merge #6765
012d636 
6765: Closes #6764 Clear notifications and download jobs when onTaskRemoved or onDestroy are called. r=rocketsroger a=Amejia481




Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
@bors bors bot closed this as completed in b34be03 Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Amejia481 Amejia481

Labels
<download>
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Amejia481