Skip to content
This repository was archived by the owner on Nov 1, 2022. It is now read-only.

Fixes #3169: Refreshes GV session after crash #3170

Closed
wants to merge 1 commit into from
Closed

Fixes #3169: Refreshes GV session after crash #3170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...ngine-gecko-beta/src/main/java/mozilla/components/browser/engine/gecko/GeckoEngineView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,13 @@ class GeckoEngineView @JvmOverloads constructor(
if (crashed) {
// When crashing the previous GeckoSession is no longer usable. Internally GeckoEngineSession will
// create a new instance. This means we will need to tell GeckoView about this new GeckoSession:
currentSession?.let { currentGeckoView.setSession(it.geckoSession) }
currentSession?.let {
currentGeckoView.setSession(it.geckoSession)
// Load the session again
it.currentUrl?.let { url ->
it.loadUrl(url)
}
}
}
}
override fun onAppPermissionRequest(permissionRequest: PermissionRequest) = Unit
Expand Down
8 changes: 7 additions & 1 deletion ...ne-gecko-nightly/src/main/java/mozilla/components/browser/engine/gecko/GeckoEngineView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,13 @@ class GeckoEngineView @JvmOverloads constructor(
if (crashed) {
// When crashing the previous GeckoSession is no longer usable. Internally GeckoEngineSession will
// create a new instance. This means we will need to tell GeckoView about this new GeckoSession:
currentSession?.let { currentGeckoView.setSession(it.geckoSession) }
currentSession?.let {
currentGeckoView.setSession(it.geckoSession)
// Load the session again
it.currentUrl?.let { url ->
it.loadUrl(url)
}
}
}
}
override fun onAppPermissionRequest(permissionRequest: PermissionRequest) = Unit
Expand Down