Skip to content
This repository was archived by the owner on Nov 1, 2022. It is now read-only.

Closes #8752 - Use coverUntilFirstPaint() with PreferredColorScheme #8797

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Closes #8752 - Use coverUntilFirstPaint() with PreferredColorScheme #8797

merged 1 commit into from
Oct 29, 2020

Conversation

ekager
Copy link
Contributor

@ekager ekager commented Oct 26, 2020

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@ekager ekager added the 🕵️‍♀️ needs review PRs that need to be reviewed label Oct 26, 2020
@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2020

This pull request has conflicts when rebasing. Could you fix it @ekager? 🙏

@ekager ekager force-pushed the 8752-color-scheme branch from f6a3332 to 011a7df Compare October 27, 2020 17:59
@csadilek csadilek self-assigned this Oct 28, 2020
csadilek
csadilek reviewed Oct 28, 2020
View reviewed changes
Copy link
Contributor

@csadilek csadilek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, can't wait to ⛔ 📸 .

Just one change and let's add a test.

@ekager ekager force-pushed the 8752-color-scheme branch from 011a7df to e60a901 Compare October 28, 2020 23:05
csadilek
csadilek approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@csadilek csadilek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Thanks for adding the tests! Let's 🚢 it.

@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2020

This pull request has conflicts when rebasing. Could you fix it @ekager? 🙏

@ekager ekager force-pushed the 8752-color-scheme branch from e60a901 to 1c0ed8d Compare October 29, 2020 15:59
@ekager ekager added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Oct 29, 2020
@mergify mergify bot merged commit 1d15599 into mozilla-mobile:master Oct 29, 2020
@ekager ekager mentioned this pull request Nov 1, 2020
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Amejia481 Amejia481 Awaiting requested review from Amejia481

@pocmo pocmo Awaiting requested review from pocmo

1 more reviewer

@csadilek csadilek csadilek approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@csadilek csadilek

Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekager @csadilek