Fix nits

mozilla-mobile · Mar 20, 2019 · 04ebf13 · 04ebf13
1 parent 214cf41
commit 04ebf13
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 11 deletions.
diff --git a/app/src/main/res/layout/fragment_crash_reporter.xml b/app/src/main/res/layout/fragment_crash_reporter.xml
@@ -1,4 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
+<!-- This Source Code Form is subject to the terms of the Mozilla Public
+   - License, v. 2.0. If a copy of the MPL was not distributed with this
+   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 <androidx.constraintlayout.widget.ConstraintLayout
         xmlns:android="http://schemas.android.com/apk/res/android"
         xmlns:app="http://schemas.android.com/apk/res-auto"
@@ -28,7 +31,7 @@
             android:singleLine="false"
             android:text="@string/tab_crash_title"
             android:textAlignment="center"
-            android:textColor="@android:color/black"
+            android:textColor="@color/search_text"
             android:textSize="20sp"
             app:layout_constraintEnd_toEndOf="parent"
             app:layout_constraintStart_toStartOf="parent"
@@ -42,7 +45,7 @@
             android:lineSpacingExtra="7sp"
             android:singleLine="false"
             android:text="@string/tab_crash_description"
-            android:textColor="@android:color/black"
+            android:textColor="@color/search_text"
             android:textSize="15sp"
             app:layout_constraintEnd_toEndOf="parent"
             app:layout_constraintStart_toStartOf="parent"
@@ -52,11 +55,11 @@
             android:id="@+id/sendCrashCheckbox"
             android:layout_width="0dp"
             android:layout_height="32dp"
-            android:layout_marginBottom="24dp"
+            android:layout_marginBottom="@dimen/crash_reporter_close_tab_button_bottom_margin"
             android:buttonTint="@color/crash_page_accent"
             android:checked="true"
             android:text="@string/tab_crash_send_report"
-            android:textColor="@android:color/black"
+            android:textColor="@color/search_text"
             android:textSize="15sp"
             app:layout_constraintBottom_toTopOf="@id/restoreTabButton"
             app:layout_constraintEnd_toEndOf="parent"
@@ -68,9 +71,9 @@
             android:id="@+id/restoreTabButton"
             android:layout_width="0dp"
             android:layout_height="wrap_content"
-            android:layout_marginStart="26dp"
-            android:layout_marginEnd="26dp"
-            android:layout_marginBottom="24dp"
+            android:layout_marginStart="@dimen/crash_reporter_close_tab_button_horizontal_margin"
+            android:layout_marginEnd="@dimen/crash_reporter_close_tab_button_horizontal_margin"
+            android:layout_marginBottom="@dimen/crash_reporter_close_tab_button_bottom_margin"
             android:backgroundTint="@color/crash_page_accent"
             android:text="@string/tab_crash_restore"
             android:textColor="@color/off_white"
@@ -83,12 +86,12 @@
             android:id="@+id/closeTabButton"
             android:layout_width="0dp"
             android:layout_height="wrap_content"
-            android:layout_marginStart="26dp"
-            android:layout_marginEnd="26dp"
-            android:layout_marginBottom="24dp"
+            android:layout_marginStart="@dimen/crash_reporter_close_tab_button_horizontal_margin"
+            android:layout_marginEnd="@dimen/crash_reporter_close_tab_button_horizontal_margin"
+            android:layout_marginBottom="@dimen/crash_reporter_close_tab_button_bottom_margin"
             android:backgroundTint="@color/crash_page_off_accent"
             android:text="@string/tab_crash_close"
-            android:textColor="@android:color/black"
+            android:textColor="@color/search_text"
             android:textSize="14sp"
             app:layout_constraintBottom_toBottomOf="parent"
             app:layout_constraintStart_toStartOf="parent"

diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
@@ -3,6 +3,8 @@
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 <resources>
+    <dimen name="crash_reporter_close_tab_button_horizontal_margin">26dp</dimen>
+    <dimen name="crash_reporter_close_tab_button_bottom_margin">24dp</dimen>
     <dimen name="glyph_button_height">48dp</dimen>
     <dimen name="glyph_button_width">48dp</dimen>
     <dimen name="mozac_browser_menu_corner_radius">14dp</dimen>