Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Remove "Library" and move items #10343

Closed
vesta0 opened this issue May 1, 2020 · 5 comments
Closed

Remove "Library" and move items #10343

vesta0 opened this issue May 1, 2020 · 5 comments
Assignees
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified eng:ready Ready for engineering

Comments

@vesta0
Copy link
Collaborator

vesta0 commented May 1, 2020

Fenix "Library" is currently only accessible through the browser toolbar menu (not from the homescreen) and it only contains 2 items: Bookmarks and History

We should revisit this and determine whether we want to keep "Library" and add more items to it, or get rid of it.

┆Issue is synchronized with this Jira Task

@vesta0 vesta0 added Feature:Library feature request 🌟 New functionality and improvements labels May 1, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label May 1, 2020
@vesta0 vesta0 added needs:UX-feedback Needs UX Feedback Skittle labels May 1, 2020
@yoasif
Copy link
Contributor

yoasif commented May 1, 2020

I vote for getting rid of it -- it doesn't work very well in Firefox desktop either as a concept, and that feels to me one of the only reasons to maintain it in Fenix (consistency/familiarity).

@lime124
Copy link
Collaborator

lime124 commented May 6, 2020

@topotropic

@topotropic
Copy link

Since we only have two items in the library (bookmarks, history) atm and we link to both directly from the home menu anyway, I propose to remove the library screen and update the site menu to reflect this.

Todo's:

  • remove "Library" header in home menu
  • remove "Library" entry from site menu
  • add "Bookmarks" and "History" to site menu

For bottom app bar: https://share.goabstract.com/6a1bcc22-bd3a-497a-bf7b-39ec63dd2ea5?mode=design&sha=5003d5fe9c05859083b502887be98b883e93a3af
Top app bar: https://share.goabstract.com/21538152-fa26-4a7a-95d7-a75d220d1b25?mode=design&sha=5003d5fe9c05859083b502887be98b883e93a3af

@topotropic topotropic removed their assignment May 6, 2020
@topotropic topotropic added eng:ready Ready for engineering and removed needs:UX-feedback Needs UX Feedback labels May 6, 2020
@vesta0 vesta0 removed the Skittle label May 7, 2020
@ValentinTimisica ValentinTimisica self-assigned this May 7, 2020
@liuche liuche changed the title Investigate usefulness of "Library" Remove "Library" May 7, 2020
@liuche liuche changed the title Remove "Library" Remove "Library" and move items May 7, 2020
@vesta0 vesta0 removed the needs:triage Issue needs triage label May 7, 2020
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue May 11, 2020
Also adds Bookmarks and History items to browser menu.
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue May 11, 2020
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue May 11, 2020
ekager pushed a commit that referenced this issue May 11, 2020
Also adds Bookmarks and History items to browser menu.
@ekager ekager added the eng:qa:needed QA Needed label May 11, 2020
@vesta0 vesta0 removed feature request 🌟 New functionality and improvements Feature:Library labels May 12, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented May 12, 2020

Hi, verified as fixed on the latest Nightly Build 200512 from 5/12 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

► Screenshots
Screenshot_20200512-145010

✔️ Performed smoke tests on both Bookmarks and History sections and haven't found any regressions
✔️ Checked the telemetry ( ⋮ Main menu event type pings )

Bookmarks

"events": [
        {
          "category": "events",
          "extra": {
            "item": "bookmarks"
          },
          "name": "browser_menu_action"

History

"events": [
        {
          "category": "events",
          "extra": {
            "item": "history"
          },
          "name": "browser_menu_action"

@AndiAJ AndiAJ closed this as completed May 12, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 12, 2020
@liuche liuche mentioned this issue May 19, 2020
32 tasks
@lobontiumira
Copy link

Hi,
This is also verified as fixed on Beta 5.1.0-beta.1 with Samsung Galaxy Tab S6 (Android 9), and Sony Xperia Z5 Premium (Android 7.1.1).
Thanks!

@liuche liuche added the E3 Estimation Point: average, 2 - 3 days label May 22, 2020
@data-sync-user data-sync-user changed the title Remove "Library" and move items FNX2-15893 ⁃ Remove "Library" and move items Jul 30, 2020
@data-sync-user data-sync-user changed the title FNX2-15893 ⁃ Remove "Library" and move items FNX-3448 ⁃ Remove "Library" and move items Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX-3448 ⁃ Remove "Library" and move items FNX3-13824 ⁃ Remove "Library" and move items Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-13824 ⁃ Remove "Library" and move items FNX-3448 ⁃ Remove "Library" and move items Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-3448 ⁃ Remove "Library" and move items FNX2-15893 ⁃ Remove "Library" and move items Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-15893 ⁃ Remove "Library" and move items Remove "Library" and move items May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified eng:ready Ready for engineering
Projects
None yet
Development

No branches or pull requests

10 participants