Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Create a "ResetAfter" function for StrictMode that checks for debug mode #11617

Closed
sraturi opened this issue Jun 15, 2020 · 0 comments · Fixed by #11619
Closed

Create a "ResetAfter" function for StrictMode that checks for debug mode #11617

sraturi opened this issue Jun 15, 2020 · 0 comments · Fixed by #11619
Assignees
@sraturi
Labels
needs:triage Issue needs triage

Comments

@sraturi
Copy link
Contributor

sraturi commented Jun 15, 2020 •
edited by data-sync-user
Loading

Problem
Currently, there is a StrictMode.resetAfter function in AC. However, the function does not check for debug mode, When this function is called in a production build, it ends up costing us 1-2 milliseconds resetting violation policies each time.

Acceptance Criteria

  • The function reset strict mode policies only in the debug mode. Otherwise, simply runs the passed-in function block.
  • replace all the existing calls to AC's resetAfter function

┆Issue is synchronized with this Jira Task
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 15, 2020
@sraturi sraturi self-assigned this Jun 15, 2020
sraturi added a commit to sraturi/fenix that referenced this issue Jun 15, 2020
@sraturi
for mozilla-mobile#11617 added a resetPoliciesAfter function, and rep…
c2248ff 
…laced all the "resetAfter" with "resetPoliciesAfter"

checking for debug

lint check
@sraturi sraturi linked a pull request Jun 15, 2020 that will close this issue
for #11617 added a resetPoliciesAfter function, and replaced all the … #11619
Merged
4 tasks
sraturi added a commit to sraturi/fenix that referenced this issue Jun 16, 2020
@sraturi
for mozilla-mobile#11617 added a resetPoliciesAfter function, and rep…
b997985 
…laced all the "resetAfter" with "resetPoliciesAfter"

checking for debug

lint check

testing why ui test failing

reverting back
sraturi added a commit that referenced this issue Jun 16, 2020
@sraturi
for #11617 added a resetPoliciesAfter ext function for StrictMode, an…
36b1c71 
…d replaced all existing calls to "resetAfter" with "resetPoliciesAfter" (#11619)
@data-sync-user data-sync-user changed the title Create a "ResetAfter" function for StrictMode that checks for debug mode FNX2-16583 ⁃ Create a "ResetAfter" function for StrictMode that checks for debug mode Aug 1, 2020
@data-sync-user data-sync-user changed the title FNX2-16583 ⁃ Create a "ResetAfter" function for StrictMode that checks for debug mode FNX3-14773 ⁃ Create a "ResetAfter" function for StrictMode that checks for debug mode Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-14773 ⁃ Create a "ResetAfter" function for StrictMode that checks for debug mode FNX-12588 ⁃ Create a "ResetAfter" function for StrictMode that checks for debug mode Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12588 ⁃ Create a "ResetAfter" function for StrictMode that checks for debug mode FNX2-16583 ⁃ Create a "ResetAfter" function for StrictMode that checks for debug mode Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16583 ⁃ Create a "ResetAfter" function for StrictMode that checks for debug mode Create a "ResetAfter" function for StrictMode that checks for debug mode May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sraturi sraturi

Labels
needs:triage Issue needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

for #11617 added a resetPoliciesAfter function, and replaced all the … sraturi/fenix
2 participants
@sraturi @data-sync-user