Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

for #11617 added a resetPoliciesAfter function, and replaced all the … #11619

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

sraturi
Copy link
Contributor

@sraturi sraturi commented Jun 15, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

Copy link
Contributor

@MarcLeclair MarcLeclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2020

Codecov Report

Merging #11619 into master will decrease coverage by 0.01%.
The diff coverage is 15.38%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11619      +/-   ##
============================================
- Coverage     21.55%   21.53%   -0.02%     
  Complexity      700      700              
============================================
  Files           373      374       +1     
  Lines         15066    15077      +11     
  Branches       2036     2037       +1     
============================================
  Hits           3247     3247              
- Misses        11537    11548      +11     
  Partials        282      282              
Impacted Files Coverage Δ Complexity Δ
...ug/java/org/mozilla/fenix/DebugFenixApplication.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rc/main/java/org/mozilla/fenix/FenixApplication.kt 12.67% <0.00%> (ø) 4.00 <0.00> (ø)
...pp/src/main/java/org/mozilla/fenix/HomeActivity.kt 8.87% <0.00%> (ø) 10.00 <0.00> (ø)
...g/mozilla/fenix/components/TabCollectionStorage.kt 9.37% <0.00%> (ø) 1.00 <0.00> (ø)
.../src/main/java/org/mozilla/fenix/ext/StrictMode.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...g/mozilla/fenix/components/AccountAbnormalities.kt 90.24% <100.00%> (ø) 9.00 <0.00> (ø)
...c/main/java/org/mozilla/fenix/whatsnew/WhatsNew.kt 95.23% <100.00%> (ø) 4.00 <0.00> (ø)
app/src/main/java/org/mozilla/fenix/Config.kt 33.33% <0.00%> (ø) 2.00% <0.00%> (ø%)
.../java/org/mozilla/fenix/utils/RunWhenReadyQueue.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3535bec...b997985. Read the comment docs.

…laced all the "resetAfter" with "resetPoliciesAfter"

checking for debug

lint check

testing why ui test failing

reverting back
@sraturi sraturi merged commit 36b1c71 into mozilla-mobile:master Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a "ResetAfter" function for StrictMode that checks for debug mode
3 participants