Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Move "what's new" behind feature flag #21574

Closed
eliserichards opened this issue Sep 29, 2021 · 3 comments · Fixed by #21575
Closed

Move "what's new" behind feature flag #21574

eliserichards opened this issue Sep 29, 2021 · 3 comments · Fixed by #21575
Assignees
@eliserichards
Labels
eng:qa:verified QA Verified Feature:HomeScreen needs:triage Issue needs triage
Milestone
94

Comments

@eliserichards
Copy link
Contributor

eliserichards commented Sep 29, 2021 •
edited by data-sync-user
Loading

Re: conversation with @betsymi and @vesta0, we should keep this behind a flag until the copy is finalized.

┆Issue is synchronized with this Jira Task
@eliserichards eliserichards self-assigned this Sep 29, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 29, 2021
eliserichards added a commit to eliserichards/fenix that referenced this issue Sep 29, 2021
@eliserichards
For mozilla-mobile#21574: Move the homescreen onboarding card behind …
453c4ed 
…a feature flag
@eliserichards eliserichards mentioned this issue Sep 29, 2021
Merged
3 tasks
@eliserichards eliserichards linked a pull request Sep 29, 2021 that will close this issue
For #21574: Move the homescreen onboarding card behind a feature flag #21575
Merged
3 tasks
eliserichards added a commit to eliserichards/fenix that referenced this issue Sep 29, 2021
@eliserichards
For mozilla-mobile#21574: Move the homescreen onboarding card behind …
012b022 
…a feature flag
eliserichards added a commit to eliserichards/fenix that referenced this issue Sep 29, 2021
@eliserichards
For mozilla-mobile#21574: Move the homescreen onboarding card behind …
16c7ffd 
…a feature flag
@mergify mergify bot closed this as completed in #21575 Sep 29, 2021
mergify bot pushed a commit that referenced this issue Sep 29, 2021
@eliserichards @mergify
For #21574: Move the homescreen onboarding card behind a feature flag
02614eb
@eliserichards eliserichards reopened this Sep 30, 2021
@eliserichards eliserichards added the eng:qa:needed QA Needed label Sep 30, 2021
@eliserichards
Copy link
Contributor Author

This onboarding will only be shown on debug for now. It should not appear on Nightly.

@eliserichards eliserichards added this to the 94 milestone Sep 30, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Oct 1, 2021
@eliserichards @pkirakosyan
For mozilla-mobile#21574: Move the homescreen onboarding card behind …
7472705 
…a feature flag
@eliserichards eliserichards removed the eng:qa:needed QA Needed label Oct 5, 2021
@eliserichards
Copy link
Contributor Author

Removing qa-needed since this has been fixed and the feature flag is removed

Amejia481 added a commit to Amejia481/fenix that referenced this issue Oct 5, 2021
@Amejia481
For mozilla-mobile#21574: disabled the homescreen onboarding dialog.
2d766f0
Amejia481 added a commit to Amejia481/fenix that referenced this issue Oct 5, 2021
@Amejia481
For mozilla-mobile#21574: disabled the homescreen onboarding dialog.
130d091
Amejia481 added a commit to Amejia481/fenix that referenced this issue Oct 5, 2021
@Amejia481
For mozilla-mobile#21574: disabled the homescreen onboarding dialog.
f3e1a92
Amejia481 added a commit to Amejia481/fenix that referenced this issue Oct 6, 2021
@Amejia481
For mozilla-mobile#21574: disabled the homescreen onboarding dialog.
3f7bab5
mergify bot pushed a commit that referenced this issue Oct 6, 2021
@Amejia481 @mergify
For #21574: disabled the homescreen onboarding dialog.
7e3a2ba
mergify bot pushed a commit that referenced this issue Oct 6, 2021
@Amejia481
For #21574: disabled the homescreen onboarding dialog.
0ccec3c 
(cherry picked from commit 7e3a2ba)
Amejia481 added a commit that referenced this issue Oct 6, 2021
@Amejia481
For #21574: disabled the homescreen onboarding dialog.
62118be 
(cherry picked from commit 7e3a2ba)
@LaurentiuApahideanSV
Copy link

Verified as fixed on Firefox Preview 94.0.0-beta.2.

Devices used:

  • Huawei MediaPad M3 (Android 7)
  • Oppo Find X3 (Android 11)

pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@Amejia481 @pkirakosyan
For mozilla-mobile#21574: disabled the homescreen onboarding dialog.
3b08a5c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eliserichards eliserichards

Labels
eng:qa:verified QA Verified Feature:HomeScreen needs:triage Issue needs triage
Projects
None yet
Milestone
94
Development

Successfully merging a pull request may close this issue.

For #21574: Move the homescreen onboarding card behind a feature flag eliserichards/fenix
2 participants
@eliserichards @LaurentiuApahideanSV