This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
View a tab group #2205
Assignees
Labels
Milestone
Comments
|
@mheubusch could you take a look at this story and add some acceptance criteria for what you'd like to see? |
sblatz
added a commit
that referenced
this issue
May 6, 2019
* For #1574: Adds collections to home view * Adds colored icons and expansion * Adds state change * Adds more styling * Adds ItsNotBrokenSnacks * Adds chevron * Improves styling of swipe to delete and adds delete action * Fix nits * Try to add real saving
|
Waiting for some acceptance criteria from @mheubusch so I can move this to "QA needed" |
sblatz
added
🙅 waiting
sblatz
added a commit
to sblatz/fenix
that referenced
this issue
May 7, 2019
sblatz
added a commit
to sblatz/fenix
that referenced
this issue
May 7, 2019
sblatz
added a commit
to sblatz/fenix
that referenced
this issue
May 8, 2019
sblatz
added a commit
that referenced
this issue
May 8, 2019
sblatz
added
in progress
and removed
🙅 waiting
sblatz
added a commit
to sblatz/fenix
that referenced
this issue
May 13, 2019
sblatz
added a commit
to sblatz/fenix
that referenced
this issue
May 13, 2019
sblatz
added a commit
to sblatz/fenix
that referenced
this issue
May 14, 2019
sblatz
added a commit
to sblatz/fenix
that referenced
this issue
May 16, 2019
sblatz
added a commit
to sblatz/fenix
that referenced
this issue
May 16, 2019
sblatz
added a commit
to sblatz/fenix
that referenced
this issue
May 16, 2019
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Nov 17, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Nov 18, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Nov 19, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Nov 19, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Nov 20, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Nov 20, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Nov 20, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Nov 21, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Nov 21, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Nov 22, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Nov 23, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Nov 24, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Nov 25, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Nov 25, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Nov 25, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Nov 27, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Nov 28, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Nov 28, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Nov 29, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Dec 2, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
boek
pushed a commit
to gabrielluong/fenix
that referenced
this issue
Dec 4, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
boek
pushed a commit
to gabrielluong/fenix
that referenced
this issue
Dec 4, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Dec 4, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
gabrielluong
added a commit
that referenced
this issue
Dec 5, 2019
* For #5574 - Part 1: Port TabAction.SaveTabGroup to TabSessionInteractor and SessionControlController. (#6651) - Introduces the TabSessionInteractor, SessionControlInteractor and SessionControlController classes. - Removes the TabAction.SaveTabGroup. * For #5574 - Part 2: Port TabAction.PrivateBrowsingLearnMore to TabSessionInteractor and SessionControlController (#6651) * For #5574 - Part 3: Port TabAction.ShareTabs to TabSessionInteractor and SessionControlController (#6651) * For #5574 - Part 4: Remove unused TabAction.Share and TabItemMenu (#6651) In #2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers. * For #5574 - Part 5: Port TabAction.PlayMedia and TabAction.PauseMedia to TabSessionInteractor and SessionControlController (#6651) * For #5574 - Part 6: Port TabAction.Select to TabSessionInteractor and SessionControlController (#6651) * For #5574 - Part 7: Port Onboarding.Finish to OnboardingInteractor and SessionControlController (#6651) * For #5574 - Part 8: Port TabAction.Close and TabAction.CloseAll to TabSessionInteractor and SessionControlController (#6651) - Removes TabAction * For #5574 - Part 9: Port CollectionAction.Delete to CollectionInteractor and SessionControlController (#6651) * For #5574 - Part 10: Port CollectionAction.ShareTabs to CollectionInteractor and SessionControlController (#6651) * For #5574 - Part 11: Port CollectionAction.AddTab and CollectionAction.Rename to CollectionInteractor and SessionControlController (#6651) * For #5574 - Part 12: Port CollectionAction.RemoveTab to CollectionInteractor and SessionControlController (#6651) * For #5574 - Part 13: Port CollectionAction.OpenTab to CollectionInteractor and SessionControlController (#6651) * For #5574 - Part 14: Port CollectionAction.CloseTabs to CollectionInteractor and SessionControlController (#6651) * For #5574 - Part 15: Introduce a HomeFragmentStore (#6651) - We will hook up the HomeFragmentStore in later parts. - Removes List<Tab>.toSessionBundle(context: Context) since it is unused. * For #5574 - Part 16: Port CollectionAction.Collapse and CollectionAction.Expand to CollectionInteractor and SessionControlController (#6651) - We assume the store is hooked up to the SessionControlController in this part, but this work will be done in a later part. - Removes CollectionAction. * For #5574 - Part 20: Remove the architecture module. (#6651) * For #5574 - Part 17: Remove duplicate subscribeToTabCollections in BrowserFragment.kt (#6651) There is a duplicate call of subscribeToTabCollections() in both HomeFragment and BrowserFragment. In this patch, we remove the call in BrowserFragment to avoid passing the HomeFragmentStore to BrowserFragment in order to dispatch the CollectionsChange event. * For #5574 - Part 18: Delete SessionControlComponent and fix TabCollection and Tab imports (#6651) * For #5574 - Part 19: Use the new HomeFragmentStore in the HomeFragment (#6651) - Renames SessionControlUIView to SessionControlView * For #5574 - Part 21: Fix white screen on home fragment (#6651) * For #5574 - Part 22: Fix formatting in SessionControlInteractor and replace See with @see in SessionControlController (#6651) * For #5574 - Part 23: Move to metrics.track call to the beginning of handleCollectionRemoveTab (#6651) This ensures that the metrics.track will be called immediately before the tab is removed from the collection. * For #5574 - Part 24: Use the sessionManager getter in SessionControlController (#6651) * For #5574 - Part 25: Use mapNotNull in List<Tab>.toSessionBundle (#6651) * For #5574 - Part 26: Simplify closeTab and closeAllTabs functions by assigning a deletionJob constant (#6651) * For #5574 - Part 27: Replace listOf() with emptyList() in removeAllTabsWithUndo (#6651) * For #5574 - Part 28: Replace the Context parameter with the HomeActivity in SessionControlController (#6651) * For #5574 - Part 29: Add test for HomeFragmentStore, DefaultSessionControlController and SessionControlInteractor (#6651) * For #5574 - Removes running CI against the architecture debug build varient
data-sync-user
changed the title
data-sync-user
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As a user, I'd like to view my tab groups I've previously created on the home screen (underneath my current tabs).
@bifleming: we didn't have a user story created for this, and it's a requirement for this feature. I've been working on it this week as a part of #1574, but this is less about the creation flow and more about the end result of that (as seen in the mocks here). Just wanted to have this work tracked somewhere. I've moved it into the current sprint, and I'd suggest it's sized at an 8 (based on the amount of work I've put in so far, and the work left).
Not sure how this slipped through the cracks--perhaps there's a user story tracking this that I'm missing?
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: