This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #5574 - Migrate SessionControl to LibState #6651
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this pull request
Nov 17, 2019
…ControlInteractor and SessionControlController. (mozilla-mobile#6651) - Introduces the SessionControlInteractor and SessionControlController classes. - Removes the TabAction.SaveTabGroup.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this pull request
Nov 17, 2019
…n to SessionControlInteractor and SessionControlController (mozilla-mobile#6651)
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this pull request
Nov 17, 2019
…n to SessionControlInteractor and SessionControlController (mozilla-mobile#6651)
Codecov Report
@@ Coverage Diff @@
## master #6651 +/- ##
============================================
+ Coverage 17.33% 18.61% +1.28%
- Complexity 392 413 +21
============================================
Files 281 282 +1
Lines 11240 11144 -96
Branches 1548 1519 -29
============================================
+ Hits 1948 2075 +127
+ Misses 9139 8908 -231
- Partials 153 161 +8
Continue to review full report at Codecov.
|
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this pull request
Nov 17, 2019
…trolInteractor and SessionControlController (mozilla-mobile#6651)
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this pull request
Nov 17, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this pull request
Nov 17, 2019
…ionControlInteractor and SessionControlController. (mozilla-mobile#6651) - Introduces the SessionControlInteractor and SessionControlController classes. - Removes the TabAction.SaveTabGroup.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this pull request
Nov 17, 2019
…More to SessionControlInteractor and SessionControlController (mozilla-mobile#6651)
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this pull request
Nov 17, 2019
…ControlInteractor and SessionControlController (mozilla-mobile#6651)
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this pull request
Nov 17, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this pull request
Nov 17, 2019
…ion.PauseMedia to SessionControlInteractior and SessionControlControler (mozilla-mobile#6651)
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this pull request
Nov 17, 2019
…ion.PauseMedia to SessionControlInteractor and SessionControlController (mozilla-mobile#6651)
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this pull request
Nov 17, 2019
…ractor and SessionControlController (mozilla-mobile#6651)
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this pull request
Nov 17, 2019
…nteractor and SessionControlController (mozilla-mobile#6651)
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this pull request
Nov 17, 2019
…nteractor and SessionControlController (mozilla-mobile#6651)
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this pull request
Nov 17, 2019
…nteractor and SessionControlController (mozilla-mobile#6651)
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this pull request
Nov 18, 2019
…essionInteractor and SessionControlController. (mozilla-mobile#6651) - Introduces the TabSessionInteractor, SessionControlInteractor and SessionControlController classes. - Removes the TabAction.SaveTabGroup.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this pull request
Nov 18, 2019
…More to TabSessionInteractor and SessionControlController (mozilla-mobile#6651)
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this pull request
Nov 18, 2019
…ionInteractor and SessionControlController (mozilla-mobile#6651)
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this pull request
Nov 18, 2019
…abItemMenu (mozilla-mobile#6651) In mozilla-mobile#2205, the tab overflow button was removed which would have shown the TabItemMenu when clicked. So, we can remove TabItemMenu since it is not used and as a result, we can also remove TabAction.Share since there are no consumers.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this pull request
Nov 18, 2019
…ion.PauseMedia to TabSessionInteractor and SessionControlController (mozilla-mobile#6651)
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this pull request
Nov 18, 2019
…actor and SessionControlController (mozilla-mobile#6651)
…Interactor and SessionControlController (mozilla-mobile#6651)
…gInteractor and SessionControlController (mozilla-mobile#6651)
…CloseAll to TabSessionInteractor and SessionControlController (mozilla-mobile#6651) - Removes TabAction
…lectionInteractor and SessionControlController (mozilla-mobile#6651)
… CollectionInteractor and SessionControlController (mozilla-mobile#6651)
…ollectionAction.Rename to CollectionInteractor and SessionControlController (mozilla-mobile#6651)
… CollectionInteractor and SessionControlController (mozilla-mobile#6651)
…ollectionInteractor and SessionControlController (mozilla-mobile#6651)
… CollectionInteractor and SessionControlController (mozilla-mobile#6651)
…illa-mobile#6651) - We will hook up the HomeFragmentStore in later parts. - Removes List<Tab>.toSessionBundle(context: Context) since it is unused.
… CollectionAction.Expand to CollectionInteractor and SessionControlController (mozilla-mobile#6651) - We assume the store is hooked up to the SessionControlController in this part, but this work will be done in a later part. - Removes CollectionAction.
…lections in BrowserFragment.kt (mozilla-mobile#6651) There is a duplicate call of subscribeToTabCollections() in both HomeFragment and BrowserFragment. In this patch, we remove the call in BrowserFragment to avoid passing the HomeFragmentStore to BrowserFragment in order to dispatch the CollectionsChange event.
… fix TabCollection and Tab imports (mozilla-mobile#6651)
…he HomeFragment (mozilla-mobile#6651) - Renames SessionControlUIView to SessionControlView
…teractor and replace See with @see in SessionControlController (mozilla-mobile#6651)
…beginning of handleCollectionRemoveTab (mozilla-mobile#6651) This ensures that the metrics.track will be called immediately before the tab is removed from the collection.
…essionControlController (mozilla-mobile#6651)
… functions by assigning a deletionJob constant (mozilla-mobile#6651)
…in removeAllTabsWithUndo (mozilla-mobile#6651)
… the HomeActivity in SessionControlController (mozilla-mobile#6651)
…faultSessionControlController and SessionControlInteractor (mozilla-mobile#6651)
… debug build varient
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5574.
Pull Request checklist
After merge
To download an APK when reviewing a PR: