Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #5574 - Migrate SessionControl to LibState #6651

Merged
merged 30 commits into from
Dec 5, 2019

Conversation

gabrielluong
Copy link
Member

@gabrielluong gabrielluong commented Nov 17, 2019

Fixes #5574.


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

gabrielluong added a commit to gabrielluong/fenix that referenced this pull request Nov 17, 2019
…ControlInteractor and SessionControlController. (mozilla-mobile#6651)

- Introduces the SessionControlInteractor and SessionControlController classes.
- Removes the TabAction.SaveTabGroup.
gabrielluong added a commit to gabrielluong/fenix that referenced this pull request Nov 17, 2019
…n to SessionControlInteractor and SessionControlController (mozilla-mobile#6651)
gabrielluong added a commit to gabrielluong/fenix that referenced this pull request Nov 17, 2019
…n to SessionControlInteractor and SessionControlController (mozilla-mobile#6651)
@codecov-io
Copy link

codecov-io commented Nov 17, 2019

Codecov Report

Merging #6651 into master will increase coverage by 1.28%.
The diff coverage is 46.41%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6651      +/-   ##
============================================
+ Coverage     17.33%   18.61%   +1.28%     
- Complexity      392      413      +21     
============================================
  Files           281      282       +1     
  Lines         11240    11144      -96     
  Branches       1548     1519      -29     
============================================
+ Hits           1948     2075     +127     
+ Misses         9139     8908     -231     
- Partials        153      161       +8
Impacted Files Coverage Δ Complexity Δ
.../fenix/collections/CollectionCreationInteractor.kt 8.33% <ø> (ø) 0 <0> (ø) ⬇️
...ix/collections/CollectionCreationTabListAdapter.kt 30.98% <ø> (ø) 4 <0> (ø) ⬇️
app/src/main/java/org/mozilla/fenix/ext/Session.kt 90.9% <ø> (ø) 0 <0> (ø) ⬇️
.../java/org/mozilla/fenix/browser/BrowserFragment.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...zilla/fenix/collections/CollectionCreationStore.kt 45.45% <ø> (ø) 1 <0> (ø) ⬇️
...lla/fenix/collections/SaveCollectionListAdapter.kt 33.33% <ø> (ø) 2 <0> (ø) ⬇️
...ozilla/fenix/collections/CollectionCreationView.kt 34.1% <ø> (ø) 6 <0> (ø) ⬇️
...la/fenix/collections/CollectionCreationFragment.kt 89.58% <ø> (ø) 6 <0> (ø) ⬇️
.../fenix/collections/CollectionCreationController.kt 25.49% <ø> (ø) 0 <0> (ø) ⬇️
...c/main/java/org/mozilla/fenix/ext/TabCollection.kt 100% <ø> (ø) 0 <0> (ø) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1b134c...e434218. Read the comment docs.

gabrielluong added a commit to gabrielluong/fenix that referenced this pull request Nov 17, 2019
gabrielluong added a commit to gabrielluong/fenix that referenced this pull request Nov 17, 2019
…abItemMenu (mozilla-mobile#6651)

In mozilla-mobile#2205, the tab overflow button was removed which would have shown the
TabItemMenu when clicked. So, we can remove TabItemMenu since it is not
used and as a result, we can also remove TabAction.Share since there are
no consumers.
gabrielluong added a commit to gabrielluong/fenix that referenced this pull request Nov 17, 2019
…ionControlInteractor and SessionControlController. (mozilla-mobile#6651)

- Introduces the SessionControlInteractor and SessionControlController classes.
- Removes the TabAction.SaveTabGroup.
gabrielluong added a commit to gabrielluong/fenix that referenced this pull request Nov 17, 2019
…More to SessionControlInteractor and SessionControlController (mozilla-mobile#6651)
gabrielluong added a commit to gabrielluong/fenix that referenced this pull request Nov 17, 2019
gabrielluong added a commit to gabrielluong/fenix that referenced this pull request Nov 17, 2019
…abItemMenu (mozilla-mobile#6651)

In mozilla-mobile#2205, the tab overflow button was removed which would have shown the
TabItemMenu when clicked. So, we can remove TabItemMenu since it is not
used and as a result, we can also remove TabAction.Share since there are
no consumers.
gabrielluong added a commit to gabrielluong/fenix that referenced this pull request Nov 17, 2019
…ion.PauseMedia to SessionControlInteractior and SessionControlControler (mozilla-mobile#6651)
gabrielluong added a commit to gabrielluong/fenix that referenced this pull request Nov 17, 2019
…ion.PauseMedia to SessionControlInteractor and SessionControlController (mozilla-mobile#6651)
gabrielluong added a commit to gabrielluong/fenix that referenced this pull request Nov 17, 2019
gabrielluong added a commit to gabrielluong/fenix that referenced this pull request Nov 17, 2019
gabrielluong added a commit to gabrielluong/fenix that referenced this pull request Nov 17, 2019
gabrielluong added a commit to gabrielluong/fenix that referenced this pull request Nov 17, 2019
gabrielluong added a commit to gabrielluong/fenix that referenced this pull request Nov 18, 2019
…essionInteractor and SessionControlController. (mozilla-mobile#6651)

- Introduces the TabSessionInteractor, SessionControlInteractor and SessionControlController classes.
- Removes the TabAction.SaveTabGroup.
gabrielluong added a commit to gabrielluong/fenix that referenced this pull request Nov 18, 2019
…More to TabSessionInteractor and SessionControlController (mozilla-mobile#6651)
gabrielluong added a commit to gabrielluong/fenix that referenced this pull request Nov 18, 2019
gabrielluong added a commit to gabrielluong/fenix that referenced this pull request Nov 18, 2019
…abItemMenu (mozilla-mobile#6651)

In mozilla-mobile#2205, the tab overflow button was removed which would have shown the
TabItemMenu when clicked. So, we can remove TabItemMenu since it is not
used and as a result, we can also remove TabAction.Share since there are
no consumers.
gabrielluong added a commit to gabrielluong/fenix that referenced this pull request Nov 18, 2019
…ion.PauseMedia to TabSessionInteractor and SessionControlController (mozilla-mobile#6651)
gabrielluong added a commit to gabrielluong/fenix that referenced this pull request Nov 18, 2019
gabrielluong and others added 24 commits December 4, 2019 17:57
…CloseAll to TabSessionInteractor and SessionControlController (mozilla-mobile#6651)

- Removes TabAction
… CollectionInteractor and SessionControlController (mozilla-mobile#6651)
…ollectionAction.Rename to CollectionInteractor and SessionControlController (mozilla-mobile#6651)
… CollectionInteractor and SessionControlController (mozilla-mobile#6651)
… CollectionInteractor and SessionControlController (mozilla-mobile#6651)
…illa-mobile#6651)

- We will hook up the HomeFragmentStore in later parts.
- Removes List<Tab>.toSessionBundle(context: Context) since it is unused.
… CollectionAction.Expand to CollectionInteractor and SessionControlController (mozilla-mobile#6651)

- We assume the store is hooked up to the SessionControlController in this part,
but this work will be done in a later part.
- Removes CollectionAction.
…lections in BrowserFragment.kt (mozilla-mobile#6651)

There is a duplicate call of subscribeToTabCollections() in both HomeFragment and BrowserFragment.
In this patch, we remove the call in BrowserFragment to avoid passing the HomeFragmentStore to
BrowserFragment in order to dispatch the CollectionsChange event.
…he HomeFragment (mozilla-mobile#6651)

- Renames SessionControlUIView to SessionControlView
…teractor and replace See with @see in SessionControlController (mozilla-mobile#6651)
…beginning of handleCollectionRemoveTab (mozilla-mobile#6651)

This ensures that the metrics.track will be called immediately before the tab is removed from the collection.
…faultSessionControlController and SessionControlInteractor (mozilla-mobile#6651)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate SessionControl to LibState
5 participants