This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Define "tags" for metrics in the app repository #22956
Assignees
Milestone
Comments
|
Pull request implementing this functionality (needs an upgrade to the glean gradle plugin before it can land): #22954 |
rocketsroger
added a commit
to rocketsroger/fenix
that referenced
this issue
Jan 18, 2022
…sitory Co-authored-by: William Lachance <wlach@protonmail.com> Define "tags" for metrics in the app repository Using the new "tags" feature in Glean, we can remove most of the manual process/pain of defining tags in a seperate Glean annotations repository (see: https://github.com/mozilla-mobile/fenix/wiki/Add-a-Glean-Annotation-for-an-event) and just put them beside the metrics themselves. This should make it much easier to keep this metadata up to date, since it can be added in the same pull request as the instrumentation itself. To keep the list of tags up to date with the Fenix issue labels, a new script `update-glean-tags.py` has been added to the repository. It should not need to be run often. This pull request uses a scraped version of the defined tags in the Glean annotations repository. After it lands, we can remove those and just use the tagging information here as the main source of information.
eliserichards
pushed a commit
to eliserichards/fenix
that referenced
this issue
Jan 31, 2022
…sitory Co-authored-by: William Lachance <wlach@protonmail.com> Define "tags" for metrics in the app repository Using the new "tags" feature in Glean, we can remove most of the manual process/pain of defining tags in a seperate Glean annotations repository (see: https://github.com/mozilla-mobile/fenix/wiki/Add-a-Glean-Annotation-for-an-event) and just put them beside the metrics themselves. This should make it much easier to keep this metadata up to date, since it can be added in the same pull request as the instrumentation itself. To keep the list of tags up to date with the Fenix issue labels, a new script `update-glean-tags.py` has been added to the repository. It should not need to be run often. This pull request uses a scraped version of the defined tags in the Glean annotations repository. After it lands, we can remove those and just use the tagging information here as the main source of information.
rvandermeulen
pushed a commit
that referenced
this issue
Jan 31, 2022
* For #22870: Renew/remove metrics set to expire in February (#23453) * For #22870: Renew/remove metrics set to expire in February * Add data review and add notification owner for never expire metrics * Close #22956: Define "tags" for metrics in the app repository Co-authored-by: William Lachance <wlach@protonmail.com> Define "tags" for metrics in the app repository Using the new "tags" feature in Glean, we can remove most of the manual process/pain of defining tags in a seperate Glean annotations repository (see: https://github.com/mozilla-mobile/fenix/wiki/Add-a-Glean-Annotation-for-an-event) and just put them beside the metrics themselves. This should make it much easier to keep this metadata up to date, since it can be added in the same pull request as the instrumentation itself. To keep the list of tags up to date with the Fenix issue labels, a new script `update-glean-tags.py` has been added to the repository. It should not need to be run often. This pull request uses a scraped version of the defined tags in the Glean annotations repository. After it lands, we can remove those and just use the tagging information here as the main source of information. Co-authored-by: Roger Yang <royang@mozilla.com>
mergify bot
pushed a commit
that referenced
this issue
Jan 31, 2022
* For #22870: Renew/remove metrics set to expire in February (#23453) * For #22870: Renew/remove metrics set to expire in February * Add data review and add notification owner for never expire metrics * Close #22956: Define "tags" for metrics in the app repository Co-authored-by: William Lachance <wlach@protonmail.com> Define "tags" for metrics in the app repository Using the new "tags" feature in Glean, we can remove most of the manual process/pain of defining tags in a seperate Glean annotations repository (see: https://github.com/mozilla-mobile/fenix/wiki/Add-a-Glean-Annotation-for-an-event) and just put them beside the metrics themselves. This should make it much easier to keep this metadata up to date, since it can be added in the same pull request as the instrumentation itself. To keep the list of tags up to date with the Fenix issue labels, a new script `update-glean-tags.py` has been added to the repository. It should not need to be run often. This pull request uses a scraped version of the defined tags in the Glean annotations repository. After it lands, we can remove those and just use the tagging information here as the main source of information. Co-authored-by: Roger Yang <royang@mozilla.com> (cherry picked from commit 08790a0)
pkirakosyan
pushed a commit
to gexsi/user-agent-android
that referenced
this issue
Mar 9, 2022
…sitory Co-authored-by: William Lachance <wlach@protonmail.com> Define "tags" for metrics in the app repository Using the new "tags" feature in Glean, we can remove most of the manual process/pain of defining tags in a seperate Glean annotations repository (see: https://github.com/mozilla-mobile/fenix/wiki/Add-a-Glean-Annotation-for-an-event) and just put them beside the metrics themselves. This should make it much easier to keep this metadata up to date, since it can be added in the same pull request as the instrumentation itself. To keep the list of tags up to date with the Fenix issue labels, a new script `update-glean-tags.py` has been added to the repository. It should not need to be run often. This pull request uses a scraped version of the defined tags in the Glean annotations repository. After it lands, we can remove those and just use the tagging information here as the main source of information.
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
To make it easier to find Fenix metrics assigned to a particular feature area, we assign metrics tags. You can use them in the Glean Dictionary to quickly narrow down areas of interest. For example:
https://dictionary.telemetry.mozilla.org/apps/fenix?page=1&search=tags%3AWebExtensions
Currently the telemetry "tags" for Fenix are defined in the glean-annotations repository. For example:
https://github.com/mozilla/glean-annotations/tree/main/annotations/fenix/metrics/bookmarks_management.open_in_new_tabs
This has proven cumbersome to maintain (see, for example, this wiki page). The latest glean release also allows defining these tags alongside the implementation, we should replace the annotations implementation with this, at least for the tags (the annotations repository also has documentation and other things stored in it, which is useful).
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: