Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Upgrade jetpack navigation & co to latest versions #25980

Closed
mcarare opened this issue Jul 11, 2022 · 0 comments · Fixed by #25991 or nathanmkaya/fenix#108
Closed

Upgrade jetpack navigation & co to latest versions #25980

mcarare opened this issue Jul 11, 2022 · 0 comments · Fixed by #25991 or nathanmkaya/fenix#108
Assignees
@mcarare
Labels
Android:13 Issues specific to Android 13 - API 33 needs:triage Issue needs triage
Milestone
107

Comments

@mcarare
Copy link
Contributor

mcarare commented Jul 11, 2022 •
edited by data-sync-user
Loading

At the time of opening this issue, the current version for navigation is 2.5.0. We aim to upgrade to 2.5.1, a version that should contain suppression of warnings in the generated safe args code. ( see https://issuetracker.google.com/issues/237725966 ).

Note: As navigation 2.5.0 depends on lifecycle 2.5.0, this issue will involve upgrading androidx.lifecycle and possibly other dependencies (core, fragment?)

┆Issue is synchronized with this Jira Task
@mcarare mcarare added the Android:13 Issues specific to Android 13 - API 33 label Jul 11, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 11, 2022
@mcarare mcarare self-assigned this Jul 11, 2022
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Replace deprecated var with corresponding m…
5f69ebe 
…ethod.
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Upgrade navigation, lifecycle, fragment and…
37729b9 
… core to latest versions.
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Separate compose compiler versioning and up…
d223220 
…grade.

See https://android-developers.googleblog.com/2022/06/independent-versioning-of-Jetpack-Compose-libraries.html
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Replace removed BottomSheetDialog style.
e557c0d
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Use new extension function to get fragment'…
a86f493 
…s NavController.
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Update method signatures for SimpleOnGestur…
bdaaac0 
…eListener.

GestureDetector onTouchEvent now expects only a NonNull MotionEvent.
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Update method signatures for onInitializeAc…
c85827b 
…cessibilityNodeInfo.
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Replace deprecated var with corresponding m…
82672a8 
…ethod.
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Replace removed static "set" method with ne…
1b7b892 
…w extension.
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Replace deprecated setHasOptionsMenu with M…
bc718a1 
…enuProvider.
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Solve overload resolution ambiguity.
f82fd21
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Replace deprecated popUpTo var.
4142a8f
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Upgrade navigation, lifecycle, fragment and…
d642379 
… core to latest versions.
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Separate compose compiler versioning and up…
8094815 
…grade.

See https://android-developers.googleblog.com/2022/06/independent-versioning-of-Jetpack-Compose-libraries.html
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Replace removed BottomSheetDialog style.
9984fcb
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Use new extension function to get fragment'…
5297172 
…s NavController.
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Update method signatures for SimpleOnGestur…
98dc6ad 
…eListener.

GestureDetector onTouchEvent now expects only a NonNull MotionEvent.
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Update method signatures for onInitializeAc…
1cb3301 
…cessibilityNodeInfo.
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Replace deprecated popUpTo var.
0d82803
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Replace removed static "set" method with ne…
c2222c7 
…w extension.
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Replace deprecated setHasOptionsMenu with M…
fbc1211 
…enuProvider.
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Solve overload resolution ambiguity.
2301d18
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Upgrade navigation, lifecycle, fragment and…
8823342 
… core to latest versions.
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Separate compose compiler versioning and up…
0c268d2 
…grade.

See https://android-developers.googleblog.com/2022/06/independent-versioning-of-Jetpack-Compose-libraries.html
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Replace removed BottomSheetDialog style.
6040436
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Use new extension function to get fragment'…
a1067e5 
…s NavController.
mcarare added a commit to mcarare/fenix that referenced this issue Jul 12, 2022
@mcarare
For mozilla-mobile#25980: Update method signatures for SimpleOnGestur…
ddb0c3a 
…eListener.

GestureDetector onTouchEvent now expects only a NonNull MotionEvent.
@mergify mergify bot closed this as completed in #25991 Oct 11, 2022
mergify bot pushed a commit that referenced this issue Oct 11, 2022
@mcarare @mergify
For #25980: Upgrade navigation, lifecycle, fragment and core to lates…
ab928ac 
…t versions.
mergify bot pushed a commit that referenced this issue Oct 11, 2022
@mcarare @mergify
For #25980: Replace removed BottomSheetDialog style.
a4696c8
mergify bot pushed a commit that referenced this issue Oct 11, 2022
@mcarare @mergify
For #25980: Use new extension function to get fragment's NavController.
4e481f4
mergify bot pushed a commit that referenced this issue Oct 11, 2022
@mcarare @mergify
For #25980: Update method signatures for SimpleOnGestureListener.
0b4d9dc 
GestureDetector onTouchEvent now expects only a NonNull MotionEvent.
mergify bot pushed a commit that referenced this issue Oct 11, 2022
@mcarare @mergify
For #25980: Update method signatures for onInitializeAccessibilityNod…
0ceeda9 
…eInfo.
mergify bot pushed a commit that referenced this issue Oct 11, 2022
@mcarare @mergify
For #25980: Replace deprecated popUpTo var.
2b8b6a9
mergify bot pushed a commit that referenced this issue Oct 11, 2022
@mcarare @mergify
For #25980: Replace deprecated setHasOptionsMenu with MenuProvider.
d9d01db
mergify bot pushed a commit that referenced this issue Oct 11, 2022
@mcarare @mergify
For #25980: Solve overload resolution ambiguity.
d9d39bd
mergify bot pushed a commit that referenced this issue Oct 11, 2022
@mcarare @mergify
For #25980: Update method signatures for View.OnAttachStateChangeList…
5e88437 
…ener.
mergify bot pushed a commit that referenced this issue Oct 11, 2022
@mcarare @mergify
For #25980: Suppress LongParameterList warning.
55724de 
Remove issues from baseline.
mergify bot pushed a commit that referenced this issue Oct 11, 2022
@mcarare @mergify
For #25980: Use new backQueue instead of removed backStack.
8ed3bf7
@github-actions github-actions bot added this to the 107 milestone Oct 11, 2022
mcarare added a commit to mcarare/fenix that referenced this issue Oct 11, 2022
@mcarare
For mozilla-mobile#25980: Add default value for appVersionName.
c654ce0
@github-actions github-actions bot mentioned this issue Oct 11, 2022
Merged
3 tasks
mcarare added a commit to mcarare/fenix that referenced this issue Oct 11, 2022
@mcarare
For mozilla-mobile#25980: Handle appVersionName nullability.
4354e65 
Add default value for appVersionName.
Add safe call for appVersion.
@Mugurell Mugurell mentioned this issue Oct 20, 2022
Closed
@github-actions github-actions bot mentioned this issue Nov 11, 2022
Merged
@Mugurell Mugurell mentioned this issue Nov 14, 2022
Merged
4 tasks
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@mcarare @mergify
[fenix] For mozilla-mobile/fenix#25980: Upgrade navigation, lifecycle…
5d475f3 
…, fragment and core to latest versions.
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@mcarare @mergify
[fenix] For mozilla-mobile/fenix#25980: Replace removed BottomSheetDi…
87e02fb 
…alog style.
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@mcarare @mergify
[fenix] For mozilla-mobile/fenix#25980: Use new extension function to…
8fbd511 
… get fragment's NavController.
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@mcarare @mergify
[fenix] For mozilla-mobile/fenix#25980: Update method signatures for …
971a40c 
…SimpleOnGestureListener.

GestureDetector onTouchEvent now expects only a NonNull MotionEvent.
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@mcarare @mergify
[fenix] For mozilla-mobile/fenix#25980: Update method signatures for …
c00bc44 
…onInitializeAccessibilityNodeInfo.
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@mcarare @mergify
[fenix] For mozilla-mobile/fenix#25980: Replace deprecated popUpTo var.
8b76385
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@mcarare @mergify
[fenix] For mozilla-mobile/fenix#25980: Replace deprecated setHasOpti…
9bbc6cc 
…onsMenu with MenuProvider.
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@mcarare @mergify
[fenix] For mozilla-mobile/fenix#25980: Solve overload resolution amb…
9762c42 
…iguity.
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@mcarare @mergify
[fenix] For mozilla-mobile/fenix#25980: Update method signatures for …
1413d46 
…View.OnAttachStateChangeListener.
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@mcarare @mergify
[fenix] For mozilla-mobile/fenix#25980: Suppress LongParameterList wa…
c1b4ff8 
…rning.

Remove issues from baseline.
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@mcarare @mergify
[fenix] For mozilla-mobile/fenix#25980: Use new backQueue instead of …
fafd4b7 
…removed backStack.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
Android:13 Issues specific to Android 13 - API 33 needs:triage Issue needs triage
Projects
None yet
Milestone
107
1 participant
@mcarare