Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Remove all unnecessary Theme.getTheme() calls from usages of FirefoxTheme #27854

Closed
Tracked by #24339
MozillaNoah opened this issue Nov 15, 2022 · 2 comments · Fixed by #27889, Leland-Takamine/fenix#159, fork-house/fenix#14 or nathanmkaya/fenix#108
Closed
Tracked by #24339

Remove all unnecessary Theme.getTheme() calls from usages of FirefoxTheme #27854

MozillaNoah opened this issue Nov 15, 2022 · 2 comments · Fixed by #27889, Leland-Takamine/fenix#159, fork-house/fenix#14 or nathanmkaya/fenix#108
Assignees
@BFadairo
Labels
compose Tickets involving Composable changes eng:health Improve code health good first issue Good for newcomers
Milestone
109

Comments

@MozillaNoah
Copy link
Contributor

MozillaNoah commented Nov 15, 2022 •
edited by data-sync-user
Loading

We have a lot of instances of FirefoxTheme(theme = Theme.getTheme()) { ... } when the default parameter for FirefoxTheme.theme is already Theme.getTheme(), making this instantiation redundant. All of these uses should be cleaned up to remove noise from the Compose code.

┆Issue is synchronized with this Jira Task
@MozillaNoah MozillaNoah added good first issue Good for newcomers eng:health Improve code health compose Tickets involving Composable changes labels Nov 15, 2022
@MozillaNoah MozillaNoah mentioned this issue Nov 15, 2022
Merged
4 tasks
@github-actions github-actions bot added the needs:triage Issue needs triage label Nov 15, 2022
@MozillaNoah MozillaNoah removed the needs:triage Issue needs triage label Nov 15, 2022
@MozillaNoah MozillaNoah mentioned this issue Nov 16, 2022
Closed
30 tasks
@BFadairo
Copy link
Contributor

Hello! Could I pick this up?

@MozillaNoah
Copy link
Contributor Author

Hello! Could I pick this up?

Sure!

BFadairo added a commit to BFadairo/fenix that referenced this issue Nov 17, 2022
@BFadairo
Closes mozilla-mobile#27854: Remove unnecessary Theme.getTheme() call…
036c69b 
…s from FirefoxTheme usages
@github-actions github-actions bot mentioned this issue Nov 17, 2022
Merged
4 tasks
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Nov 17, 2022
@github-actions github-actions bot removed the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Nov 17, 2022
BFadairo added a commit to BFadairo/fenix that referenced this issue Nov 18, 2022
@BFadairo
For mozilla-mobile#27854: Remove missed Theme.getTheme() calls in Fir…
58d1628 
…efoxTheme usages
BFadairo added a commit to BFadairo/fenix that referenced this issue Nov 21, 2022
@BFadairo
Closes mozilla-mobile#27854: Remove unnecessary Theme.getTheme() call…
34ae19d 
…s from FirefoxTheme usages
This was referenced Nov 21, 2022
Closed
Closed
@mergify mergify bot closed this as completed in #27889 Nov 22, 2022
@github-actions github-actions bot added this to the 109 milestone Nov 22, 2022
mergify bot pushed a commit that referenced this issue Nov 22, 2022
@BFadairo @mergify
Closes #27854: Remove unnecessary Theme.getTheme() calls from Firefox…
71bc9eb 
…Theme usages
This was referenced Jan 5, 2023
Merged
Merged
Merged
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@BFadairo @mergify
[fenix] Closes mozilla-mobile/fenix#27854: Remove unnecessary Theme.g…
7ecd7c8 
…etTheme() calls from FirefoxTheme usages
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@BFadairo BFadairo

Labels
compose Tickets involving Composable changes eng:health Improve code health good first issue Good for newcomers
Projects
None yet
Milestone
109
2 participants
@BFadairo @MozillaNoah