Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Meta] Update Detekt version #7360

Closed
shahsurajk opened this issue Dec 24, 2019 · 0 comments · Fixed by #9306
Closed

[Meta] Update Detekt version #7360

shahsurajk opened this issue Dec 24, 2019 · 0 comments · Fixed by #9306
Labels
eng:build Build system, gradle, configuration eng:health Improve code health eng:quality An optional polish ticket that is nice to have P2 Upcoming release

Comments

@shahsurajk
Copy link
Contributor

shahsurajk commented Dec 24, 2019 •
edited by data-sync-user

Why/User Benefit/User Problem

  • The current used version of detekt is an "RC" and not a "GA", plus it's super old (released in Jun 1), we're using 1.0.0-RC16 while the current GA is at 1.3.0

Acceptance Criteria (Added by PM. For EPM to track when a Meta feature is done)

  • Dependency updated.

What / Requirements (Added by PM and Eng Manager)

-UX Designs (Immediate task: Assign UX issue to this epic)
-User stories (to be created by PM)
-List dependencies on other issues/teams etc.

PS: should add a "help wanted" and "good first issue" tag on this.

┆Issue is synchronized with this Jira Task
@boek boek added eng:health Improve code health eng:quality An optional polish ticket that is nice to have P2 Upcoming release labels Dec 27, 2019
@kbrosnan kbrosnan added the eng:build Build system, gradle, configuration label Jan 11, 2020
gaul added a commit to gaul/fenix that referenced this issue Mar 3, 2020
@gaul
Upgrade to detekt 1.6.0
81be823 
Changelog:

https://arturbosch.github.io/detekt/changelog.html

Fixes mozilla-mobile#7360.
@gaul gaul mentioned this issue Mar 3, 2020
Closed
4 tasks
gaul added a commit to gaul/fenix that referenced this issue Mar 14, 2020
@gaul
Upgrade to detekt 1.6.0
e7c80d3 
Changelog:

https://arturbosch.github.io/detekt/changelog.html

Fixes mozilla-mobile#7360.
gaul added a commit to gaul/fenix that referenced this issue Mar 15, 2020
@gaul
Upgrade to detekt 1.6.0
8ef3388 
Changelog:

https://arturbosch.github.io/detekt/changelog.html

Fixes mozilla-mobile#7360.  Also use more exact test glob.
ekager pushed a commit to ekager/fenix that referenced this issue Mar 21, 2020
@gaul @ekager
Upgrade to detekt 1.6.0
c7254f7 
Changelog:

https://arturbosch.github.io/detekt/changelog.html

Fixes mozilla-mobile#7360.  Also use more exact test glob.
@ekager ekager mentioned this issue Mar 21, 2020
Merged
4 tasks
gaul added a commit to gaul/fenix that referenced this issue Mar 22, 2020
@gaul
Upgrade to detekt 1.6.0
a64e4dc 
Changelog:

https://arturbosch.github.io/detekt/changelog.html

Fixes mozilla-mobile#7360.  Also use more exact test glob.
ekager pushed a commit to ekager/fenix that referenced this issue Mar 27, 2020
@gaul @ekager
Upgrade to detekt 1.7.0
f7709bd 
Changelog:

https://arturbosch.github.io/detekt/changelog.html

Fixes mozilla-mobile#7360.  Also use more exact test glob.
ekager pushed a commit to ekager/fenix that referenced this issue Mar 28, 2020
@gaul @ekager
Upgrade to detekt 1.6.0
c591393 
Changelog:

https://arturbosch.github.io/detekt/changelog.html

Fixes mozilla-mobile#7360.  Also use more exact test glob.
@boek boek closed this as completed in #9306 Apr 1, 2020
boek pushed a commit that referenced this issue Apr 1, 2020
@ekager @gaul
Upgrade to detekt 1.6.0 (#9306)
b94ac93 
Changelog:

https://arturbosch.github.io/detekt/changelog.html

Fixes #7360.  Also use more exact test glob.

Co-authored-by: Andrew Gaul <andrew@gaul.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
eng:build Build system, gradle, configuration eng:health Improve code health eng:quality An optional polish ticket that is nice to have P2 Upcoming release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to detekt 1.6.0 ekager/fenix
Upgrade to detekt 1.6.0 gaul/fenix
3 participants
@kbrosnan @boek @shahsurajk