Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bookmarks] No bookmarks here strings are close to the top #8649

Closed
AmyYLee opened this issue Feb 21, 2020 · 6 comments
Closed

[Bookmarks] No bookmarks here strings are close to the top #8649

AmyYLee opened this issue Feb 21, 2020 · 6 comments
Labels
eng:qa:verified QA Verified Feature:Bookmarks good first issue Good for newcomers help wanted Help wanted from a contributor. More complex than good first issue.

Comments

@AmyYLee
Copy link
Collaborator

AmyYLee commented Feb 21, 2020 •
edited by data-sync-user
Loading

Please reference empty state in "History"
image

Please reference History screen below

image

┆Issue is synchronized with this Jira Task
@darkwing
Copy link
Contributor

darkwing commented Mar 3, 2020

@AmyYLee Where would the "Sign in" button go? Same spot? Middle of the screen?

@AmyYLee
Copy link
Collaborator Author

AmyYLee commented Mar 3, 2020

@AmyYLee Where would the "Sign in" button go? Same spot? Middle of the screen?

yes can you move the copy and button to the middle of the screen. Thanks!

@AmyYLee AmyYLee added the P2 Upcoming release label Mar 13, 2020
@eliserichards eliserichards self-assigned this Mar 16, 2020
@eliserichards eliserichards removed the needs:triage Issue needs triage label Mar 17, 2020
eliserichards added a commit to eliserichards/fenix that referenced this issue Mar 25, 2020
@eliserichards
Fixes mozilla-mobile#8649: wrap bookmark layout in constraint view. I…
f757d48 
…nclude sign in component in bookmarks in relation to the empty view text.
eliserichards added a commit to eliserichards/fenix that referenced this issue Mar 25, 2020
@eliserichards
Fixes mozilla-mobile#8649: wrap bookmark layout in constraint view. I…
9e82c70 
…nclude sign in component in bookmarks in relation to the empty view text.
@ekager ekager mentioned this issue Apr 18, 2020
Closed
@vesta0
Copy link
Collaborator

vesta0 commented May 12, 2020

@eliserichards what is the status of this issue?

@liuche liuche added good first issue Good for newcomers and removed good first issue Good for newcomers labels Jun 3, 2020
@eliserichards eliserichards added Feature:Bookmarks good first issue Good for newcomers help wanted Help wanted from a contributor. More complex than good first issue. and removed P2 Upcoming release implementation review labels Jun 8, 2020
@eliserichards eliserichards removed their assignment Jun 8, 2020
ekager pushed a commit to ekager/fenix that referenced this issue Jun 15, 2020
@ekager
For mozilla-mobile#8649: No bookmarks here strings are close to the top
eb5b9df
ekager pushed a commit to ekager/fenix that referenced this issue Jun 17, 2020
@ekager
For mozilla-mobile#8649: No bookmarks here strings are close to the top
4439e16
ekager pushed a commit that referenced this issue Jun 22, 2020
@ekager
For #8649: No bookmarks here strings are close to the top
c8d36dd
@ekager ekager added the eng:qa:needed QA Needed label Jun 22, 2020
@person808
Copy link
Contributor

@ekager Seems like this fix makes the sign in button overlap the last row in landscape mode on my Pixel 3 emulator.

Screenshot_1592858407

ekager added a commit to ekager/fenix that referenced this issue Jun 22, 2020
@ekager
For mozilla-mobile#8649 - Fixes overlapping bookmark sign in button
da2f2c5
ekager added a commit that referenced this issue Jun 22, 2020
@ekager
For #8649 - Fixes overlapping bookmark sign in button
761d253
@ekager
Copy link
Contributor

ekager commented Jun 22, 2020

Good catch! Should be fixed by #11828

@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 23, 2020

Hi, verified as fixed on the latest Nightly Build 200623 from 6/23 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

► Video
20200623-133000

@AndiAJ AndiAJ closed this as completed Jun 23, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 23, 2020
@liuche liuche mentioned this issue Jun 27, 2020
Closed
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
eng:qa:verified QA Verified Feature:Bookmarks good first issue Good for newcomers help wanted Help wanted from a contributor. More complex than good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@darkwing @liuche @AmyYLee @person808 @ekager @vesta0 @eliserichards @AndiAJ