Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] UriOpenedObserver not registered for restored sessions #9816

Closed
BranescuMihai opened this issue Apr 9, 2020 · 1 comment
Closed

[Bug] UriOpenedObserver not registered for restored sessions #9816

BranescuMihai opened this issue Apr 9, 2020 · 1 comment
Assignees
@boek
Labels
🐞 bug Crashes, Something isn't working, .. eng:health Improve code health eng:qa:not-needed Added by QA to issues that cannot be tested Feature:Telemetry needs:investigation

Comments

@BranescuMihai
Copy link
Contributor

BranescuMihai commented Apr 9, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

Add one or more tabs (sessions)
Close the app
Restart the app

Expected behavior

The UriOpenedObserver registers itself for restored sessions

Actual behavior

The UriOpenedObserver doesn't register itself for restored sessions.

Device information

  • Android device: All
  • Fenix version: Latest develop

Engineering notes

This happens because the restoring is done in Core.kt -> init of SessionManager (lazy init, first called in FenixApplication - setupInMainProcessOnly()), while the UriOpenedObserver is initiated much later, when we go to the BrowserFragment.

┆Issue is synchronized with this Jira Task
@BranescuMihai BranescuMihai added the 🐞 bug Crashes, Something isn't working, .. label Apr 9, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 9, 2020
This was referenced Apr 9, 2020
Closed
Closed
@kbrosnan kbrosnan added the eng:health Improve code health label Apr 9, 2020
boek added a commit to boek/fenix that referenced this issue Apr 21, 2020
@boek
For mozilla-mobile#9816 - Adds SessionObserver to session on selection
14037f6
ekager pushed a commit that referenced this issue Apr 21, 2020
@boek @ekager
For #9816 - Adds SessionObserver to session on selection
164e6cd
@ekager ekager added the eng:qa:needed QA Needed label Apr 21, 2020
@ekager
Copy link
Contributor

ekager commented Apr 21, 2020

Thanks for filing! We investigated and decided the core of this issue was that we aren't registering on selected sessions or the first selected session. So we've added those and this should be fixed!

@ekager ekager removed the eng:qa:needed QA Needed label Apr 21, 2020
@ekager ekager closed this as completed Apr 21, 2020
@ekager ekager added the eng:qa:not-needed Added by QA to issues that cannot be tested label Apr 21, 2020
@liuche liuche mentioned this issue Apr 28, 2020
Closed
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@boek boek

Labels
🐞 bug Crashes, Something isn't working, .. eng:health Improve code health eng:qa:not-needed Added by QA to issues that cannot be tested Feature:Telemetry needs:investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kbrosnan @boek @BranescuMihai @ekager @vesta0 @eliserichards